Closed
Bug 560344
Opened 16 years ago
Closed 16 years ago
Website updates for 0.3 release
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dbuchner, Assigned: dbuchner)
References
Details
Attachments
(9 files)
|
319 bytes,
patch
|
Details | Diff | Splinter Review | |
|
1.11 KB,
patch
|
myk
:
review-
|
Details | Diff | Splinter Review |
|
1.99 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.50 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.52 KB,
patch
|
myk
:
review-
|
Details | Diff | Splinter Review |
|
4.50 KB,
patch
|
myk
:
review-
|
Details | Diff | Splinter Review |
|
3.54 KB,
patch
|
myk
:
review-
|
Details | Diff | Splinter Review |
|
7.66 KB,
patch
|
myk
:
review-
|
Details | Diff | Splinter Review |
|
7.70 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
https://jetpack.mozillalabs.com/ -
* Links need to be pointed at the 0.3 sources
Google Groups:
Post advanced notice 2 days prior to release date
| Assignee | ||
Comment 1•16 years ago
|
||
| Assignee | ||
Updated•16 years ago
|
Assignee: nobody → dbuchner
Comment 2•16 years ago
|
||
Would it be possible to work bug 560711 into these changes?
| Assignee | ||
Comment 3•16 years ago
|
||
If we were to do a redirect, should it be a 301 and not on page level?
Comment 4•16 years ago
|
||
A 301 sounds OK to me. Seems like we should archive the old tutorial somewhere though, since people are still free to use the prototype. https://developer.mozilla.org/en/Jetpack for example links to the old tutorial. And if we archive it, a warning that it applies to the prototype and not the SDK.
I didn't mean for this to block 0.3 though, if it needs more thought or is time consuming to do.
Comment 5•16 years ago
|
||
Comment on attachment 440369 [details] [diff] [review]
Patch for jetpack.mozillalabs.com site in prep for 0.3 release
This patch doesn't seem to contain any changes (it references an image change but doesn't actually include it, and it doesn't contain any text changes). Can you attach a new version of the patch with the proposed changes to the site? Make sure to make the patch with the --git option. It might help to include some or all of the following in your ~/.hgrc file:
[defaults]
diff=-U 8 -p
qdiff=-U 8
# suppress noisy extdiff header message
cdiff=-q
[diff]
git=true
showfunc=true
[extdiff]
cmd.cdiff = colordiff
opts.cdiff = -U8 -prN
Note: I just created "latest" symlinks that link to the latest version of the SDK packages. When updating references to jetpack-sdk-0.2.tar.gz and jetpack-sdk-0.2.zip, change them to jetpack-sdk-latest.tar.gz and jetpack-sdk-latest.zip, so we don't need to update them again in the future.
Regarding bug 560711, I'm happy to include a fix for it in these changes. Rather than creating a 301 redirect, though, let's put a notice at the top of the page explaining that it applies to the prototype and directing readers to the SDK tutorial. Here's what it should say:
Note: This page is a tutorial for the
<a href="https://jetpack.mozillalabs.com/prototype.html">Jetpack
Prototype</a>, which is no longer under active development. Are you looking
for the
<a href="https://jetpack.mozillalabs.com/sdk/latest/docs/">tutorial for the
Jetpack SDK</a>?
| Assignee | ||
Comment 6•16 years ago
|
||
| Assignee | ||
Comment 7•16 years ago
|
||
Comment 8•16 years ago
|
||
Comment on attachment 441890 [details] [diff] [review]
link changes for 0.3
It looks like the links in this patch (and the other one) point to the "0.3" packages rather than the "latest" packages. Now that we have "latest" symlinks that always point to the latest versions of the packages, can you change those links to point to those packages instead? They are:
https://ftp.mozilla.org/pub/mozilla.org/labs/jetpack/jetpack-sdk-latest.tar.gz
https://ftp.mozilla.org/pub/mozilla.org/labs/jetpack/jetpack-sdk-latest.zip
Also, can you add the notice described in comment 5 to the top of the tutorial page?
Attachment #441890 -
Flags: review-
| Assignee | ||
Comment 9•16 years ago
|
||
| Assignee | ||
Comment 10•16 years ago
|
||
Updated•16 years ago
|
Attachment #441983 -
Flags: review?(myk)
Comment 11•16 years ago
|
||
Comment on attachment 441983 [details] [diff] [review]
Seriously, this is the final patch, seriously.
This patch doesn't apply to the tree. It looks like it's a patch to your earlier patch. Can you provide a patch that applies to the current tip of the repository?
Attachment #441983 -
Flags: review?(myk) → review-
| Assignee | ||
Comment 12•16 years ago
|
||
| Assignee | ||
Comment 13•16 years ago
|
||
OK so this time I just dumped my repo and did a fresh clone - if that doesn't do it, I might just cry.
Comment 14•16 years ago
|
||
Comment on attachment 442118 [details] [diff] [review]
sdk-0.2 links changed to sdk-latest on tip
Note: make sure to request review from me when you have a patch! Looking at this now...
Attachment #442118 -
Flags: review?(myk)
Comment 15•16 years ago
|
||
Comment on attachment 442118 [details] [diff] [review]
sdk-0.2 links changed to sdk-latest on tip
This patch applies cleanly, and the link fixes look good. The patch still has three issues, though:
1. It doesn't include the notice at the top of the tutorial that I requested in comment 5.
2. The news.js file has a news item that says 0.2 has been released. It should have a news item saying that 0.3 has been released. Also, when fixing this, remove the double "with" typo in the news item.
3. The home page says the SDK doesn't include high-level APIs in the paragraph:
At this early development stage, the SDK includes tools for running,
testing, and packaging add-ons along with some low-level APIs for accessing
Firefox functionality, but it doesn't yet include high-level APIs. Look for
those and additional tools in future releases.
However, the SDK does now include some high-level APIs, so change this paragraph to read:
At this early development stage, the SDK includes tools for running,
testing, and packaging add-ons along with a variety of APIs for extending
Firefox, including an initial set of "high-level" APIs that make add-on
development simple and powerful. Look for additional high-level APIs
and tools to make add-on development even better in future releases!
Attachment #442118 -
Flags: review?(myk) → review-
| Assignee | ||
Comment 16•16 years ago
|
||
Updated•16 years ago
|
Attachment #442198 -
Flags: review?(myk)
Comment 17•16 years ago
|
||
Comment on attachment 442198 [details] [diff] [review]
Added other changes to content to better reflect SDK status
This needs to be a patch against the latest version of the code in the central repository. Also, don't forget to remove one of the duplicate "with" words in the news item in news.js.
Attachment #442198 -
Flags: review?(myk) → review-
| Assignee | ||
Comment 18•16 years ago
|
||
| Assignee | ||
Updated•16 years ago
|
Attachment #442207 -
Flags: review?(myk)
Comment 19•16 years ago
|
||
Comment on attachment 442207 [details] [diff] [review]
0.3 content in one patch
This looks good, except that you didn't remove one of the duplicate "with" words in the news item in news.js.
Attachment #442207 -
Flags: review?(myk) → review-
| Assignee | ||
Comment 20•16 years ago
|
||
Attachment #442235 -
Flags: review?(myk)
Comment 21•16 years ago
|
||
Comment on attachment 442235 [details] [diff] [review]
0.3 changes, including elimination of 'with with' word duplication.
Looks great, thanks! r=myk
Attachment #442235 -
Flags: review?(myk) → review+
Comment 22•16 years ago
|
||
Fixed by changeset http://hg.mozilla.org/labs/jetpack/rev/7c39dd056096.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 23•16 years ago
|
||
Woo! Congrats Daniel on your first patch.
Comment 24•15 years ago
|
||
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.
To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
You need to log in
before you can comment on or make changes to this bug.
Description
•