560413 - [Add-on Details] add add-on type to breadcrumbs

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Justin Scott [:fligtar]]

Please add the add-on type to the details page breadcrumbs, e.g. Add-ons for Firefox > Extensions

Comment 1

[Wil Clouser [:clouserw]]

Where does "Extensions" link to?

Comment 2

[Wil Clouser [:clouserw]]

Attachment: fix

In case fligtar doesn't want it to link to anywhere, this patch does that.  r?ing because I wonder if there is a better way to get addon_type_plural to the template.  Seems like that whole thing is template code, but I don't really want to pass amo.ADDON_TYPES to the template.  Maybe amo should be in the template already.

Comment 3

[Justin Scott [:fligtar]]

It should link to the main page for that category, like
https://preview.addons.mozilla.org/z/en-US/firefox/extensions
https://preview.addons.mozilla.org/z/en-US/firefox/themes/
https://preview.addons.mozilla.org/z/en-US/firefox/personas/
etc.

Comment 4

[Jeff Balogh (:jbalogh)]

Comment on attachment 440249 [details] [diff] [review]
fix

r- since this isn't what fligtar wants.

amo is already available in the template.

This should probably do ``addon.type.get_url_path()`` and let the AddonType tell you where to go.

Comment 5

[Wil Clouser [:clouserw]]

good idea.  r? http://github.com/clouserw/zamboni/commit/b4f19db55d8acf1f6e7eb517e1e95e9008313d06

Comment 6

[Wil Clouser [:clouserw]]

http://github.com/jbalogh/zamboni/commit/e738501c20f7ac4455fce66fadea7773226384e6

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; this looks good on:

https://preview.addons.mozilla.org/z/en-US/firefox/personas/
https://preview.addons.mozilla.org/z/en-US/firefox/extensions/toolbars/

(etc.)


But not on:

https://preview.addons.mozilla.org/z/en-US/firefox/themes/
https://preview.addons.mozilla.org/z/en-US/firefox/language-tools

(and it's probably not going to work for search engines and plugins, if it doesn't work for the above two, either)

Comment 8

[Wil Clouser [:clouserw]]

We're calling that a dupe of bug 561448.  The plan is just to comment the whole breadcrumb out for this release since this was a bonus bug.  Davedash is going to do that in the other bug...which makes this hard to verify I guess!  [qa-] for now! :)

Comment 9

[krupa raj[:krupa]]

moving this to 5.11,so that QA can verify it when it gets re-enabled.

Comment 10

[Justin Scott [:fligtar]]

Can we re-enable this yet? I miss it

Comment 11

[Wil Clouser [:clouserw]]

(In reply to comment #10)
> Can we re-enable this yet? I miss it

We should reopen it at least.

Comment 12

[Wil Clouser [:clouserw]]

This is back and looking good.  "Dictionaries" isn't linked on dictionary pages because we don't have a landing page for just that (it's combined).  If you're thinking about complaining about that in this bug, please open a different one. Thx. :)

http://github.com/jbalogh/zamboni/commit/8f44b31590ac4e9d2c9beaea6e88013e3ecd9b4b