560451 - Fennec allows uninstall attempt of add-ons in root-owned directories

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Extension Compatibility, defect)

Description

[Jaakko Kiviluoto]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US) AppleWebKit/533.4 (KHTML, like Gecko) Chrome/5.0.375.3 Safari/533.4
Build Identifier: Fennec 1.1a2pre

Fennec does not check if the install location of an add-on is accessible. The uninstall button in Extension Manager should be disabled if the user does not have write access rights to the add-on's files.

Reproducible: Always

Steps to Reproduce:
1. As root, install an add-on from a .deb package so that it lands under /usr/lib/fennec/extensions, which is not writable by current user
2. Go to extension manager, select the installed add-on and tap "Uninstall" button
Actual Results:  
2. Add-on seems to be uninstalled, but actually is not

Expected Results:  
2. The "Uninstall" button should be disabled

Comment 1

[Jaakko Kiviluoto]

Attachment: Proposed fix

Adds "isReadOnly" attribute to extension list items, which will be used to disable the uninstall button if the add-on can not be uninstalled by current user.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 440148 [details] [diff] [review]
Proposed fix

Code looks good.

Thanks for the patch :)

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 440148 [details] [diff] [review]
Proposed fix

The addon manager has been changed on mozilla-central and it breaks this patch. See bug 562495.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Attachment: updated patch

This patch works for me when based on the dependent patch.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 445944 [details] [diff] [review]
updated patch

Looks good. Must wait for dependent patch to land first.

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

Attachment: complete patch

/me needs to remember to recheck before attaching a patch that it's the latest one.
Sorry, there was missing one (slightly important) bit.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 446145 [details] [diff] [review]
complete patch

Yes, we'll need the anonid :)

Comment 8

[Wolfgang Rosenauer [:wolfiR]]

http://hg.mozilla.org/mobile-browser/rev/7a40d5b5552a