Closed Bug 560455 Opened 14 years ago Closed 14 years ago

<binding extends="xul:button"> creates an HTML button frame

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v2
4.11 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
... because nsCSSFrameConstructor::FindHTMLData doesn't do the namespace check quite right.
Attachment #440154 - Flags: review?(bzbarsky)
Comment on attachment 440154 [details] [diff] [review]
patch

You need to change ShouldHaveFirstLineStyle too.  And add a test, please?
Attachment #440154 - Flags: review?(bzbarsky) → review-
Attached patch patch v2 — — Splinter Review 

        Attachment #440154 -
        Attachment is obsolete: true

        Attachment #457375 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 457375 [details] [diff] [review]
patch v2

Nix the extra parens around the != check in ShouldHaveFirstLineStyle.  r=bzbarsky with that.

        Attachment #457375 -
        Flags: review?(bzbarsky) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/b1bd8e3271d8
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: