560563 - abcasm: getouterscope not supported

Status: RESOLVED FIXED

(Tamarin Graveyard :: Tools, defect)

Description

[Chris Peyer]

when trying to use getouterscope with abcasm:

line 142:1 no viable alternative at input 'getouterscope'
line 142:1 Unimplemented opcode "getouterscope"

Comment 1

[Edwin Smith]

Attachment: Move grammar/abcasm.g3 to grammar/abcasm/abcasm.g3

This generates a folder structure easier for eclipse to grok:

gensrc/grammar/abcasm/*.java

Comment 2

[Tom Harwood]

Comment on attachment 440491 [details] [diff] [review]
Move grammar/abcasm.g3 to grammar/abcasm/abcasm.g3

Just do a diff on those two .g3 files and make sure nothing crept in there.

Comment 3

[Edwin Smith]

Attachment: Remove dead class Function

I'm adding support for OP_getouterscope, and I'd have to edit this class to keep things consistent.  better to delete the dead code, I reckon.

Comment 4

[Edwin Smith]

Attachment: add abcasm support for OP_getouterscope and OP_strictequals

Needed strictequals for the test case, one line change.  looks like support was already there in the rest of abcasm.

Comment 5

[Edwin Smith]

pushed to tamarin-redux

move grammar and delete Function.java: http://hg.mozilla.org/tamarin-redux/rev/9477ee55a4b4
add getouterscope support: http://hg.mozilla.org/tamarin-redux/rev/9477ee55a4b4