abcasm: getouterscope not supported

RESOLVED FIXED in Future

Status

Tamarin
Tools
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Chris Peyer, Assigned: Edwin Smith)

Tracking

unspecified
Future
Bug Flags:
flashplayer-qrb +

Details

Attachments

(3 attachments)

(Reporter)

Description

8 years ago
when trying to use getouterscope with abcasm:

line 142:1 no viable alternative at input 'getouterscope'
line 142:1 Unimplemented opcode "getouterscope"
Flags: flashplayer-qrb?

Updated

8 years ago
Target Milestone: --- → Future

Updated

8 years ago
Flags: flashplayer-qrb? → flashplayer-qrb+
(Assignee)

Updated

8 years ago
Blocks: 555610
(Assignee)

Comment 1

8 years ago
Created attachment 440491 [details] [diff] [review]
Move grammar/abcasm.g3 to grammar/abcasm/abcasm.g3

This generates a folder structure easier for eclipse to grok:

gensrc/grammar/abcasm/*.java
Assignee: nobody → edwsmith
Status: NEW → ASSIGNED
Attachment #440491 - Flags: review?(tharwood)

Comment 2

8 years ago
Comment on attachment 440491 [details] [diff] [review]
Move grammar/abcasm.g3 to grammar/abcasm/abcasm.g3

Just do a diff on those two .g3 files and make sure nothing crept in there.
Attachment #440491 - Flags: review?(tharwood) → review+
(Assignee)

Comment 3

8 years ago
Created attachment 440493 [details] [diff] [review]
Remove dead class Function

I'm adding support for OP_getouterscope, and I'd have to edit this class to keep things consistent.  better to delete the dead code, I reckon.
Attachment #440493 - Flags: review?(tharwood)

Updated

8 years ago
Attachment #440493 - Flags: review?(tharwood) → review+
(Assignee)

Comment 4

8 years ago
Created attachment 440498 [details] [diff] [review]
add abcasm support for OP_getouterscope and OP_strictequals

Needed strictequals for the test case, one line change.  looks like support was already there in the rest of abcasm.
Attachment #440498 - Flags: review?(tharwood)

Updated

8 years ago
Attachment #440498 - Flags: review?(tharwood) → review+
(Assignee)

Comment 5

8 years ago
pushed to tamarin-redux

move grammar and delete Function.java: http://hg.mozilla.org/tamarin-redux/rev/9477ee55a4b4
add getouterscope support: http://hg.mozilla.org/tamarin-redux/rev/9477ee55a4b4
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.