redundant filters added to filepicker for unknown content type

VERIFIED FIXED

Status

SeaMonkey
UI Design
P3
normal
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Scott MacGregor)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
In nsUnknownContentTypeHandler::PromptForSaveToFile, it appends "*.*" as a
filter if a suggested file extension couldn't be found.  This is unnecessary
since right after that, filterAll is appended.  So, there are two problems:

- two filters get added
- the *.* filter is not the correct "all files" filter on unix

I'm attaching a patch to only append a filter if we have a suggested extension.
 mscott, this appears to be from your checkin to
nsUnknownContentTypeHandler.cpp, rev. 1.33.
(Reporter)

Comment 1

17 years ago
Created attachment 16754 [details] [diff] [review]
patch
(Assignee)

Comment 2

17 years ago
ahh right you are. Good catch Brian. I messed that up. 

sr=mscott

Comment 3

17 years ago
*handing bryner some coffee*
r=brendan@mozilla.org.

/be
(Reporter)

Comment 5

17 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
QA Contact: sairuh → shrir

Comment 6

17 years ago
verified that the patch is in, marking as such. Also verified that the extra *.*
is not added. build:20001011604 trunk.
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.