Linux floating point exceptions running make check

VERIFIED FIXED in Thunderbird 3.3a1

Status

defect
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: standard8, Assigned: ginnchen+exoracle)

Tracking

Trunk
Thunderbird 3.3a1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The comm-central Linux check boxes are currently failing make check due to floating point exceptions:

TEST-PASS | TimeDuration <= operator works
TEST-PASS | TimeDuration <= operator works
TEST-PASS | TimeDuration >= operator works
TEST-PASS | TimeDuration >= operator works
TEST-PASS | TimeDuration >= operator works
TEST-PASS | Default TimeStamp value null
TEST-PASS | TimeStamp time value non-null
TEST-PASS | TimeStamp zero-length duration
TEST-PASS | TimeStamp > comparison
TEST-PASS | TimeStamp > comparison
TEST-PASS | TimeStamp < comparison
TEST-PASS | TimeStamp < comparison
TEST-PASS | TimeStamp <= comparison
TEST-PASS | TimeStamp <= comparison
TEST-PASS | TimeStamp <= comparison
TEST-PASS | TimeStamp >= comparison
TEST-PASS | TimeStamp >= comparison
TEST-PASS | TimeStamp >= comparison
TEST-PASS | TimeStamp difference lower bound
TEST-PASS | TimeStamp difference upper bound
TEST-PASS | TimeStamp negative difference lower bound
TEST-PASS | TimeStamp negative difference upper bound
/bin/sh: line 1: 13147 Floating point exceptionXPCOM_DEBUG_BREAK=stack-and-abort ../../dist/bin/run-mozilla.sh ../../dist/bin/$f
NEXT ERROR make[3]: *** [check] Error 136

Could be fallout from bug 480735.

Firefox isn't seeing these failures, so my best guesses are that it is either something related to bug 560715 (unlikely), or it could be we're using an out-of-date compiler and need to update it for the latest bug fixes.
AFAIK, I have updated the SeaMonkey boxes to the same compiler Firefox should be using - but then, since they switched to puppet, it's hard for me to figure out what exactly they are installing on their build machines (see bug 557704).
The change of TimeStamp.cpp in Bug 441767 should also apply to TimeStamp_posix.cpp.
Otherwise it is not initialized.
Posted patch patch (obsolete) — Splinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #440997 - Flags: review?(benjamin)
Attachment #440997 - Flags: review?(benjamin) → review+
(In reply to comment #2)
> The change of TimeStamp.cpp in Bug 441767 should also apply to
> TimeStamp_posix.cpp.

s/Bug 441767/bug 480735/, right?
right.

missed 1 changeset.
Didn't even see _posix, sorry!  I just landed a patch that fixes a static constructor initialization hazard, but it needs a guard in TimeStamp::Startup.  This patch adds that guard (is otherwise identical to previous).
Attachment #441555 - Flags: review?(benjamin)
Attachment #441555 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/mozilla-central/rev/1e04db0f5a30
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1272320758.1272325985.26394.gz
Linux comm-central-trunk build on 2010/04/26 15:25:58

V.Fixed
Status: RESOLVED → VERIFIED
Target Milestone: --- → Thunderbird 3.2a1
Attachment #440997 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.