Closed
Bug 560740
Opened 14 years ago
Closed 14 years ago
Cancelling the master password prompt brings up a second one for each connection
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(thunderbird3.1 beta2-fixed)
RESOLVED
FIXED
Thunderbird 3.1b2
| Tracking | Status | |
|---|---|---|
| thunderbird3.1 | --- | beta2-fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
|
3.83 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
If you have one connection (pop, imap, whatever) wanting to get a password and prompting for the master password and you cancel the dialog, you'll get a second prompt. If you have two connections, you'll get four, etc etc. The issue comes down to the fact that if login manager aborts getting the password (due to cancelling the dialog), then GetPasswordWithoutUI (the name of which technically is wrong), doesn't return that error. So then GetPasswordWithUI assumes that login manager just didn't have a password and tries to prompt - which also happens to trigger the master password prompt... The simple solution is to make GetPasswordWithoutUI return the error code.
Attachment #440385 -
Flags: superreview?(bienvenu)
Attachment #440385 -
Flags: review?(bienvenu)
|
||
Updated•14 years ago
|
Attachment #440385 -
Flags: superreview?(bienvenu)
Attachment #440385 -
Flags: superreview+
Attachment #440385 -
Flags: review?(bienvenu)
Attachment #440385 -
Flags: review+
|
Assignee | |
Comment 1•14 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/b04f949d9fb3
Status: NEW → RESOLVED
Closed: 14 years ago
status-thunderbird3.1:
--- → beta2-fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
You need to log in
before you can comment on or make changes to this bug.
Description
•