Closed Bug 560838 Opened 14 years ago Closed 14 years ago

saving html attachment using "save as" add http-equiv=context-type (x, not n)

Categories

(Core :: DOM: Serializers, defect)

Product:
Core
Component:
DOM: Serializers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b7

People

(Reporter: julian.reschke, Assigned: julian.reschke)

References

(
URL
)

Details

Attachments

(1 file)

proposed patch
948 bytes, patch
bzbarsky
: review+
jst
: approval2.0+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 (.NET CLR 3.5.30729)
Build Identifier: 3.0.4

When saving an HTML attachment using "save as", Thunderbird apparently tries to preserve the content-encoding by adding

  <meta http-equiv="Context-Type" content="text/html; charset=utf-8">

That should be

  <meta http-equiv="Content-Type" content="text/html; charset=utf-8">

right? Also prepending (outside the html/head) appears to be a bad idea.

Reproducible: Always
It appears the bug is in mozSanitizingSerializer.cpp/mozSanitizingHTMLSerializer::SetDocumentCharset
(In reply to comment #1)
> It appears the bug is in
> mozSanitizingSerializer.cpp/mozSanitizingHTMLSerializer::SetDocumentCharset

Do you feel like writing a patch ?
Product: Thunderbird → Core
QA Contact: general → general
(In reply to comment #2)
> (In reply to comment #1)
> > It appears the bug is in
> > mozSanitizingSerializer.cpp/mozSanitizingHTMLSerializer::SetDocumentCharset
> 
> Do you feel like writing a patch ?

Like replacing "x" by "n"?
Yeah and providing the patch here ... and then following the standard procedure to get the patch in.
https://developer.mozilla.org/en/Getting_your_patch_in_the_tree
URL: http://mxr.mozilla.org/seamonkey/sour...
Status: UNCONFIRMED → NEW
Component: General → Serializers
Ever confirmed: true
OS: Windows 7 → All
QA Contact: general → dom-to-text
Hardware: x86 → All
Version: unspecified → Trunk
Attached patch proposed patch — — Splinter Review 

        Attachment #473062 -
        Flags: review?(asqueella)

    
  

        Attachment #473062 -
        Flags: review?(asqueella) → review?(bzbarsky)

    
    

    
  
Comment on attachment 473062 [details] [diff] [review]
proposed patch

r=me.

Requesting approval.  This is a really safe fix; I see no reason to not take it.

        Attachment #473062 -
        Flags: review?(bzbarsky)

        Attachment #473062 -
        Flags: review+

        Attachment #473062 -
        Flags: approval2.0?

        Attachment #473062 -
        Flags: approval2.0? → approval2.0+

    
    

    
  
Pushed http://hg.mozilla.org/mozilla-central/rev/2e006f37c801
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: