560993 - Hang: CallNPN_GetValue_NPNVnetscapeWindow IPC message not delivered? hang|mozilla::plugins::PPluginInstanceParent::CallNPP_SetWindow versus hang|KiFastSystemCallRet | NtWaitForMultipleObjects | CreateFileMappingA

Status: RESOLVED WORKSFORME

(Core :: IPC, defect)

Description

[Benjamin Smedberg]

This hang-pair is shows up right near the top of the list, after ones jimm already fixed:

browser: http://crash-stats.mozilla.com/report/index/fe46dbb4-9832-40a4-a1d4-a35ea2100418
plugin (flash and silverlight): http://crash-stats.mozilla.com/report/index/14d635f6-2c1e-4e8c-8482-467df2100418

No plugin code is really involved here. The parent is instantiating a plugin, calls NPP_SetWindow quite normally.

The child does AnswerNPP_SetWindow > CreateWinlessPopupSurrogate > CallNPN_GetValue_NPNVnetscapeWindow.

The browser appears never to respond to the message. I don't know whether it was sent and never received, or received and never woke up the parent main thread, or what.

cjones/jimm, any thoughts?

Comment 1

[Jim Mathies [:jimm]]

I'm not sure what the cause is, but I can offer an alternative. We could create the surrogate parent on the fly instead of creating it for every plugin. The only time we need it is if someone right-clicks for a context menu.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Any ideas why-tf CreateFileMappingA is where it is in the child stack?

Comment 3

[Jim Mathies [:jimm]]

Attachment: smarter use of parent surrogates v.1

Comment 4

[Jim Mathies [:jimm]]

(In reply to comment #2)
> Any ideas why-tf CreateFileMappingA is where it is in the child stack?

Not our doing, windows must be processing something internally while we wait. or something. Wish I had the src!

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 440674 [details] [diff] [review]
smarter use of parent surrogates v.1

Regardless of what we come up with on this, this is a good optimization that's worth adding.

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 440674 [details] [diff] [review]
smarter use of parent surrogates v.1

>+    if (NPN_GetValue(NPNVnetscapeWindow, &hwnd)) {

Do a != NPERR_NO_ERROR check here.

>+      CreateWinlessPopupSurrogate();

I'd do this to avoid the unnecessry function call:

  if (!mWinlessPopupSurrogateHWND) {
    CreateWinlessPopupSurrogate();
    NS_ASSERTION(mWinlessPopupSurrogateHWND, "fail");
  }

Comment 7

[Benjamin Smedberg]

As much as the optimization is nice, I'm not sure it's worth taking in 3.6.4. I'm more interested in figuring out how/why the messages aren't being delivered properly.

Comment 8

[Benjamin Smedberg]

Woohoo, mw22 got STR in bug 561895.

Comment 9

[Amisha Sharma]

I am Amisha, an independent chandigarh model girl, and I'm here to serve you. You will have one of the finest orgasms of your life, I guarantee it. Book me at any moment at the most reasonable price.
❤️ https://chandigarhescortagency.in/
❤️ https://escortchandigarhagency.in/
❤️ https://escortchandigarhagency.com/

Comment 10

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

NPAPI is gone and intr is gone and I think it's likely that whatever was going here was either fixed a long time ago, removed from the codebase, or both.