561064 - Larry menu doesn't work correctly when finger is dragged from the Larry menu to awesome bar url field

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[kayttajanimi]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.11) Gecko/2009060309 Ubuntu/8.04 (hardy) Firefox/3.0.11
Build Identifier: Mozilla/5.0 (X11; U;Linux armv71; en-US; rv:1.9.2.5pre) Gecko/20100420 Namroka/3.6.5pre Fennec/1.1a2pre

When finger is dragged from Larry menu to awesome bar url field, the focus moves to url field and menu disappears. Button on the awesome bar for Larry menu stays toggled like the menu would be visible still. If you click that button it will come untoggled and only after second click you get the Larry menu to be visible again.

Reproducible: Always

Steps to Reproduce:
1. Open Larry menu
2. Drag your finger from the menu to awesome bar url field
3. Release your finger.
Actual Results:  
Button for Larry bar stays toggled even though menu is not visible anymore.

Expected Results:  
Button for Larry bar should follow state changes correctly.

Most likely this bug caused because it is not expected that focus would change to url field when dragged, so that would be the real bug behind this.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Thanks for the full of details bug report, it helps me figured what's wrong quickly!

> Most likely this bug caused because it is not expected that focus would change
> to url field when dragged, so that would be the real bug behind this.

To be exact, the "site menu" and many dialogs in Fennec are supposed to dismiss when you do something else. With that in mind we were checking if, during a "mousedown" the target is different than the "dialog" (and a few others stuff) and if it is the case just dismiss the dialog.

But in your testcase you're doing the mousedown on an authorized target and the mouseup on another non-authorized one.

patch is coming.

Thanks again.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch add a check for the event target during mouseup.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/c4b7585c7d64

Comment 4

[Aakash Desai [:aakashd]]

Cool! verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100423 Namoroka/3.6.5pre Fennec/1.1a2pre

Comment 5

[Aakash Desai [:aakashd]]

litmus testcase  https://litmus.mozilla.org/show_test.cgi?id=12932 created to regression test this bug.