Closed Bug 561094 Opened 10 years ago Closed 10 years ago

export nsAccessible.h

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

We need to export nsAccessible.h to make it visible outside an accessibility module so others modules can use it and we can switch from nsIAccessible to nsAccessible like we do in a11y module.

Also I covered nsAccessible usage doesn't confuse gdb on OS X (what was described in bug 560185).

Patch is coming.
Attached patch patchSplinter Review
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #440781 - Flags: review?(bolterbugz)
1) export nsAccessNode, nsAccessible, nsAccEvent and nsEventShell (last two can be used instead an nsIAccessibilityService::FireAccEvent)
2) introduce a11yGeneric.h which contains nsRunnable macros used in header files (like nsAccessible), it's supposed to keep all generic definitions and functions used in a11y headers.
Comment on attachment 440781 [details] [diff] [review]
patch

>+  a11yGeneric.h \

I would like to avoid "generic". Maybe a11yUtils?

>- * Mozilla Foundation.
>- * Portions created by the Initial Developer are Copyright (C) 2007
>+ * Mozilla Corporation.
>+ * Portions created by the Initial Developer are Copyright (C) 2010

I'm not sure we can do this change.

r=me otherwise
Attachment #440781 - Flags: review?(bolterbugz) → review+
(In reply to comment #3)
> (From update of attachment 440781 [details] [diff] [review])
> >+  a11yGeneric.h \
> 
> I would like to avoid "generic". Maybe a11yUtils?

utils are associated with functions/methods, here we have macros only (at least now), also I would confuse a11yUtils with accUtils.

> >- * Mozilla Foundation.
> >- * Portions created by the Initial Developer are Copyright (C) 2007
> >+ * Mozilla Corporation.
> >+ * Portions created by the Initial Developer are Copyright (C) 2010

> I'm not sure we can do this change.

I copied this file to save hg history. The new file was created in 2010 so I use it, runnable macros was added recently by me, so technically Co should be ok. However perhaps I can use either Fo or Co.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to comment #4)
> > >- * Mozilla Foundation.
> > >- * Portions created by the Initial Developer are Copyright (C) 2007
> > >+ * Mozilla Corporation.
> > >+ * Portions created by the Initial Developer are Copyright (C) 2010
> 
> > I'm not sure we can do this change.
> 
> I copied this file to save hg history. The new file was created in 2010 so I
> use it, runnable macros was added recently by me, so technically Co should be
> ok. However perhaps I can use either Fo or Co.

Nope, it's supposed to be the Foundation. See <http://weblogs.mozillazine.org/gerv/archives/2010/02/mpl_initial_developer_for_mozilla_employ.html>
Thank you for the link! I didn't know that. I think we need to fix all MoCo entries in a11y code eventually.
(In reply to comment #7)
> Thank you for the link! I didn't know that. I think we need to fix all MoCo
> entries in a11y code eventually.

I filed bug 562262.
You need to log in before you can comment on or make changes to this bug.