561139 - [k] 500 Internal Server Error searching from homepage (Opera, Safari, Chrome)

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load http://support-stage-new.mozilla.com/en-US/search?q=deleting+bookmarks using Opera 10.51 on Windows
2. Type "deleting bookmarks" and click Search

Actual Results:

500 Internal Server Error

Traceback (most recent call last):

  File "/data/virtualenvs/kitsune/src/django/django/core/handlers/base.py", line 80, in get_response
    response = middleware_method(request)

  File "/data/www/support-stage-new.mozilla.com/kitsune/apps/sumo/middleware.py", line 30, in process_request
    full_path = prefixer.fix(prefixer.shortened_path)

  File "/data/www/support-stage-new.mozilla.com/kitsune/apps/sumo/urlresolvers.py", line 104, in fix
    locale = self.locale if self.locale else self.get_language()

  File "/data/www/support-stage-new.mozilla.com/kitsune/apps/sumo/urlresolvers.py", line 95, in get_language
    return settings.LANGUAGE_URL_MAP[supported[0]]

KeyError: 'en-US'

<WSGIRequest
GET:<QueryDict: {u'q': [u'deleting bookmarks'], u'qs': [u's']}>,
POST:<QueryDict: {}>,
COOKIES:{'s_cc': 'true',
 's_sq': 'mozillasupport%3D%2526pid%253Den-US/kb%2526pidt%253D1%2526oid%253DSearch%2526oidt%253D3%2526ot%253DSUBMIT%2526oi%253D160',
 's_vi': ''},
META:{'AUTH_TYPE': 'Basic',
 'DOCUMENT_ROOT': '/data/www/support-stage-new.mozilla.com/webroot',
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTP_ACCEPT': 'text/html, application/xml;q=0.9, application/xhtml+xml, image/png, image/jpeg, image/gif, image/x-xbitmap, */*;q=0.1',
 'HTTP_ACCEPT_CHARSET': 'iso-8859-1, utf-8, utf-16, *;q=0.1',
 'HTTP_ACCEPT_ENCODING': 'deflate, gzip, x-gzip, identity, *;q=0',
 'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.9',
 'HTTP_CACHE_CONTROL': 'no-cache',
 'HTTP_CONNECTION': 'Keep-Alive, TE',
 'HTTP_COOKIE': 's_vi=[CS]v1|25E845DD850103EF-6000010BC000732D[CE]; s_cc=true; s_sq=mozillasupport%3D%2526pid%253Den-US/kb%2526pidt%253D1%2526oid%253DSearch%2526oidt%253D3%2526ot%253DSUBMIT%2526oi%253D160',
 'HTTP_COOKIE2': '$Version=1',
 'HTTP_HOST': 'support-stage-new.mozilla.com',
 'HTTP_MOZ_REQ_METHOD': 'HTTP',
 'HTTP_REFERER': 'http://support-stage-new.mozilla.com/en-US/kb/',
 'HTTP_TE': 'deflate, gzip, chunked, identity, trailers',
 'HTTP_USER_AGENT': 'Opera/9.80 (Windows NT 5.1; U; en) Presto/2.5.22 Version/10.51',
 'HTTP_X_FORWARDED_FOR': '63.245.220.240',
 'PATH_INFO': u'/search',
 'PATH_TRANSLATED': 'redirect:/k/search',
 'QUERY_STRING': 'qs=s&q=deleting+bookmarks',
 'REDIRECT_QUERY_STRING': 'qs=s&q=deleting+bookmarks',
 'REDIRECT_SCRIPT_URI': 'http://support-stage-new.mozilla.com/search',
 'REDIRECT_SCRIPT_URL': '/search',
 'REDIRECT_STATUS': '200',
 'REDIRECT_URL': '/search',
 'REMOTE_ADDR': '10.2.81.4',
 'REMOTE_PORT': '63239',
 'REMOTE_USER': 'support',
 'REQUEST_METHOD': 'GET',
 'REQUEST_URI': '/search?qs=s&q=deleting+bookmarks',
 'SCRIPT_FILENAME': '/data/www/support-stage-new.mozilla.com/kitsune/wsgi/kitsune.wsgi',
 'SCRIPT_NAME': u'',
 'SCRIPT_URI': 'http://support-stage-new.mozilla.com/search',
 'SCRIPT_URL': '/search',

Comment 1

[James Socol [:jsocol, :james]]

Looks like we assumed Accept-Language headers were lowercase. Easy fix.

Comment 2

[James Socol [:jsocol, :james]]

Paul: r? http://github.com/jsocol/kitsune/commit/e9aa5d2f87e163917ad339c0d6c06fc0b58625c2

Just cast potential dict keys to lowercase, and add a test for it.

Comment 3

[Paul Craciunoiu [:paulc]]

Looks good.

For QA: I tested this by changing intl.accept_languages in about:config

Comment 4

[James Socol [:jsocol, :james]]

http://github.com/jsocol/kitsune/commit/204df74d3b387959c60d8d2ccb7c7636592d3841

Build #43.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

* Safari 4.0.5
* Google Chrome 4.1.249.1059 (44723)
* Opera 10.51