Closed Bug 561143 Opened 16 years ago Closed 5 years ago

Add notifications to the Autoconfig code.

Categories

(Thunderbird :: Account Manager, defect)

Product:
Thunderbird
Component:
Account Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED WONTFIX

People

(Reporter: bwinton, Unassigned)

Details

Partially to make our tests easier to write, but also to let other people hook in to the process. (Ben, I'ld like to leave this bug open to track when we can make the changes to the tests, but feel free to do the work in your autoconfig rewrite bug.)
Could you please describe the bug, further than the summary? I don't know what you mean with "notifications", to start with. Or what - specifically - something wants to be notified of.
By "notifications", I mean using the Observer service to let interested pieces of code know when various things happen. In particular, the test I was writing really wanted to know when the configs had been found so that it could make sure the correct values were being used, and then hit the Manual Setup button, and make sure the correct values got propagated to the Account Wizard. I can imagine future tests wanting to make sure that the various probing steps were attempted in the correct order, so sending a notification of each of those seems like it might be another good idea.
OK, makes sense. Which exact observer service do you mean? nsIObserver/nsIObserverService, or the thing davida worked on to notify extensions, or something else? At which exact points to you need notification? I think we should probably notify when findConfig() is called, and when foundConfig() is called, with the new config as object.
I think I could work with either, but nsIObserver is probably more used. The two points you listed are probably enough for now. We can always add more later, as I add tests. ;) Thanks, Blake.

I think we can close this. Wouldn't add notifications, but if we need events we can always fire such as we need.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX

VERIFIED WONTFIX

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.