Closed
Bug 561173
Opened 16 years ago
Closed 16 years ago
Reduce QIing and Addref/Release while setting innerHTML
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
|
6.12 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
We're doing quite a bit QIing to nsIDOMNode and back to nsINode while
setting innerHTML; enough to show up in profiles.
The patch helps a bit.
There is still extra Qi for fragments, but that can be handled in another bug.
Attachment #440851 -
Flags: review?(jst)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 440851 [details] [diff] [review]
patch
- In nsContentUtils::CreateContextualFragment():
+ nsCOMPtr<nsIDocument> document = aContextNode->GetOwnerDoc();
Does this need to be a strong reference, or could it just be an nsIDocument *?
r=jst
Attachment #440851 -
Flags: review?(jst) → review+
|
Assignee | |
Comment 2•16 years ago
|
||
That was a case where I couldn't be 100% sure that it is safe to remove nsCOMPtr.
So I kept it.
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•