561173 - Reduce QIing and Addref/Release while setting innerHTML

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

We're doing quite a bit QIing to nsIDOMNode and back to nsINode while
setting innerHTML; enough to show up in profiles.

The patch helps a bit.
There is still extra Qi for fragments, but that can be handled in another bug.

Comment 1

[Johnny Stenback (:jst)]

Comment on attachment 440851 [details] [diff] [review]
patch

- In nsContentUtils::CreateContextualFragment():

+  nsCOMPtr<nsIDocument> document = aContextNode->GetOwnerDoc();

Does this need to be a strong reference, or could it just be an nsIDocument *?

r=jst

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

That was a case where I couldn't be 100% sure that it is safe to remove nsCOMPtr.
So I kept it.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/498ea1457799