Closed
Bug 561192
Opened 14 years ago
Closed 14 years ago
Rename add-on to Firefox Sync, update visuals
Categories
(Firefox :: Sync, defect)
Tracking
()
VERIFIED
FIXED
1.3b5
People
(Reporter: rags, Assigned: mconnor)
References
Details
Attachments
(1 file, 2 obsolete files)
70.83 KB,
patch
|
Mardak
:
review+
|
Details | Diff | Splinter Review |
Starting with this release, we'll be calling this the Firefox Sync add-on with the eventual goal of making Sync an integrated feature of Firefox. Sean is working on new visuals to replace the current Weave logo. Personally, it'll be sad to see the celtic knots go (hard as they are to draw by hand for us mortals).
Flags: blocking-weave1.3+
Assignee | ||
Updated•14 years ago
|
Whiteboard: [final]
Updated•14 years ago
|
Whiteboard: [final]
Target Milestone: --- → 1.3
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → mconnor
Status: NEW → ASSIGNED
Assignee | ||
Updated•14 years ago
|
Target Milestone: 1.3 → 1.3b5
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #444028 -
Attachment is obsolete: true
Attachment #444117 -
Flags: review?(edilee)
Comment 3•14 years ago
|
||
Comment on attachment 444117 [details] [diff] [review] v1 >+++ b/source/chrome/content/preferences/fx-setup.js >- let success = Weave.Status.login == Weave.LOGIN_SUCCEEDED || Weave.Status.login == Weave.LOGIN_FAILED_INVALID_PASSPHRASE; >+ let success = Weave.Status.login == Weave.LOGIN_SUCCEEDED || Weave.Status.login == Weave.LOGIN_SUCCEEDED; ? It's checking against the same value? For what?
Assignee | ||
Comment 4•14 years ago
|
||
my mq state got a little unclean here. :(
Attachment #444117 -
Attachment is obsolete: true
Attachment #444156 -
Flags: review?(edilee)
Attachment #444117 -
Flags: review?(edilee)
Updated•14 years ago
|
Attachment #444156 -
Flags: review?(edilee) → review+
Assignee | ||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/e2b53b01c357
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 6•14 years ago
|
||
This patch should have changed the key names, as it's hard to figure out that something totally different is going on now. Also, renames of products could surely use more communication, like, I had no idea that we're not talking about Weave Sync no more.
Assignee | ||
Comment 7•14 years ago
|
||
Right, I should have done the key name changes. As for communication, I thought this was widely talked about, but maybe we missed l10n. Sorry about that!
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•