561306 - Exception when importing a bug without patches

Status: RESOLVED FIXED

(Developer Services :: Mercurial: qimportbz, defect)

Description

[Serge Gautherie (:sgautherie)]

hg qimport -p bz:553890

{
Fetching... done
Parsing... done
No patches found for this bug
** unknown exception encountered, details follow
** report bug details to http://mercurial.selenic.com/bts/
** or [e-mail]
** Mercurial Distributed SCM (version 1.4.3)
** Extensions loaded: extdiff, mq, rebase, qimportbz, transplant
Traceback (most recent call last):
  File "hg", line 36, in <module>
  File "mercurial\dispatch.pyo", line 16, in run
  File "mercurial\dispatch.pyo", line 30, in dispatch
  File "mercurial\dispatch.pyo", line 46, in _runcatch
  File "mercurial\dispatch.pyo", line 454, in _dispatch
  File "mercurial\dispatch.pyo", line 324, in runcommand
  File "mercurial\dispatch.pyo", line 505, in _runcommand
  File "mercurial\dispatch.pyo", line 459, in checkargs
  File "mercurial\dispatch.pyo", line 453, in <lambda>
  File "mercurial\util.pyo", line 386, in check
  File "mercurial\extensions.pyo", line 116, in wrap
  File "mercurial\util.pyo", line 386, in check
  File "...\__init__.py", line 155, in qimporthook
    orig(ui, repo, *files, **opts)
  File "mercurial\util.pyo", line 386, in check
  File "hgext\mq.pyo", line 1783, in qimport
  File "hgext\mq.pyo", line 1669, in qimport
  File "...\__init__.py", line 138, in read
    return ui.edit(fp.read(), ui.username())
AttributeError: 'NoneType' object has no attribute 'read'
}

NB: I found this when I typo'ed bug 533890 ;->

Comment 2

[Ed Morley [:emorley]]

Attachment: MozReview Request: bz://561306/edmorley

/r/5343 - qimportbz: exit gracefully if there are no patches to import (bug 561306)

Pull down this commit:

hg pull review -r f780f8c0e97958e8bf3b9ce55ef1b36626e63249

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8577231 [details]
MozReview Request: bz://561306/edmorley

https://reviewboard.mozilla.org/r/5341/#review4389

Ship It!

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/4ca0f73b40c3

Comment 6

[Ed Morley [:emorley]]

Attachment: MozReview Request: qimportbz: exit gracefully if there are no patches to import (bug 561306)