561406 - Reset Secret Phrase doesn't show reset UI

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Tony Chung [:tchung]]

Attachment: invalid secret phrase screenshot

I am unable to change or update the secret phrase.  At the update secret phrase window, it just returns an error saying "Secret phrase incorrect, please try again."

* See screenshot

Repro:
1) install weave 1.3b1 
2) enter in an existing weave user/pass
3) at secret phrase window, type in an invalid phrase
4) The Wrong Phrase error appears with a link to "Change Secret Phrase".  click it.
5) The change secret phrase drops down.  Create a new 12-character secret phrase
6) Click Update Secret Phrase
7) Verify error says "Secret phrase is incorrect, please try again."   

Expected:
- new secret phrase within the guidelines is updated

Actual:
- secret phrase creation error fails.  Blocks you from updating it.

Comment 1

[Mike Connor [:mconnor]]

Argh, the reset link should show different UI, but only lets you enter the changed password.

Update should let you enter the changed password.

Comment 2

[Mike Connor [:mconnor]]

Attachment: implement separate behaviours for update and reset

Comment 3

[Ed Lee :Mardak]

Comment on attachment 441653 [details] [diff] [review]
implement separate behaviours for update and reset

>+++ b/source/chrome/content/preferences/fx-prefs.js
>-  changePassphrase: function () {
>-    Weave.Utils.openGenericDialog("ChangePassphrase");
>+  changePassphrase: function (doReset) {
>+    if (doReset)
>+      Weave.Utils.openGenericDialog("ResetPassphrase");
>+    else
>+      Weave.Utils.openGenericDialog("UpdatePassphrase");
fx-setup.js still opens as ChangePassphrase, so the "Change Secret Phrase" link doesn't really work. Also, this function should just be split into two instead of needing to remember if it's true or false to trigger the which one.

Also, for the original filed bug, when resetting the secret phrase on login of a second computer, it'll eventually drop back to the secret phrase page and will require the just-entered secret phrase again before continuing.

Comment 4

[Mike Connor [:mconnor]]

Attachment: v2

Also fixes the issue raised on review with the reset PP interaction, not really part of this bug, but meh.

Comment 5

[Mike Connor [:mconnor]]

http://hg.mozilla.org/labs/weave/rev/04ae76ff9378

Comment 6

[Tracy Walker [:tracy]]

verified the correct dialog appears with 1.3b2

filed bug 562030 for alerts not appearing on invalid phrases.