Closed Bug 561422 Opened 11 years ago Closed 11 years ago

Test fails for Importing settings for windows live mail

Categories

(MailNews Core :: Import, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: philbaseless-firefox, Assigned: philbaseless-firefox)

References

Details

Attachments

(1 file, 1 obsolete file)

test need a fix. Currently it cross checks all prefs but each machine may assign different ID etc so simple equality check won't work.
e.g
testvar has
mail.identity.id4.useremail    don@wingtiptoys.com

import creates data with different id number.
mail.identity.id5.useremail    don@wingtiptoys.com
Attached patch test (obsolete) — Splinter Review
removes problem prefs like references to relative number id1 id2 etc. Also absolute paths and other prefs that does not need checking.

Locates failures and dumps prefs in log for review if needed.
Attachment #442936 - Flags: review?(bugzilla)
Attachment #442936 - Attachment is obsolete: true
Attachment #442936 - Flags: review?(bugzilla)
same, made unix l/e so diff is better.
Attachment #442939 - Flags: review?(bugzilla)
Comment on attachment 442939 [details] [diff] [review]
test to check import patch

> //////////////// -- Modified nsIWindowsRegKey implementation ---
>   Components.manager
>             .unregisterFactory(Components.ID("{0478de5b-0f38-4edb-851d-4c99f1ed8eba}"),
>                                              factory);
> //////////////// -- Modified nsIWindowsRegKey 

I'd feel more comfortable putting this ahead of the do_throw()'s.
I think I was suppose to use a generated uid for that also, which I just copied it from the other test.
Comment on attachment 442939 [details] [diff] [review]
test to check import patch

Sorry in the delay to getting back to this. That's much better.
Attachment #442939 - Flags: review?(bugzilla) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/ff850f63668a

Should we also be putting this on the comm-1.9.2 branch at some stage?
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
I think we should.
Comment on attachment 442939 [details] [diff] [review]
test to check import patch

(In reply to comment #6)
> Checked in: http://hg.mozilla.org/comm-central/rev/ff850f63668a
> 
> Should we also be putting this on the comm-1.9.2 branch at some stage?
(In reply to comment #7)
> I think we should.

does test need any changes to land in 1.9.2?
Attachment #442939 - Flags: approval-thunderbird3.1.9?
Attachment #442939 - Flags: approval-thunderbird3.1.10? → approval-thunderbird3.1.10+
Backed out on branch due to test failures, which I suspect were the order of the prefs:

http://hg.mozilla.org/releases/comm-1.9.2/rev/2475533e8c3e

Start test dump
"popdisplayname","popdisplayname","testpop@invalid.invalid","testpop@invalid.invalid","test","test","mozillanews@invalid.invalid","mozillanews@invalid.invalid","Don Hall","Wingtip Toys","don@wingtiptoys.com","don@wingtiptoys.com","Don Hall","Wingtip Toys","don@wingtiptoys.com","don@wingtiptoys.com","[ProfD]News","[ProfD]ImapMail","[ProfD]News","[ProfD]Mail","[ProfD]Mail","true","false","true","true","[ProfD]Mail/pop3.test.test","pop3.test.test","true","testpopaccountname","pop3","testpopusername","[ProfD]Mail/Local Folders","Local Folders","Local Folders","none","nobody","[ProfD]News/testnews.mozilla.org","testnews.mozilla.org","accountnamemozillanews","[ProfD]News/testnews.mozilla.org.rc","nntp","true","[ProfD]News/news.wingtiptoys.com","news.wingtiptoys.com","donhallnntp","[ProfD]News/news.wingtiptoys.com.rc","nntp","don","true","[ProfD]ImapMail/mail.wingtiptoys.com","mail.wingtiptoys.com","donhallimap","Inbox","imap","don","[ProfD]News/testmsnews.microsoft.com","testmsnews.microsoft.com","Microsoft Communities Test","[ProfD]News/testmsnews.microsoft.com.rc","nntp","smtp.pop.test","smtp.wingtiptoys.com","don",
end test dump
TEST-UNEXPECTED-FAIL | e:/buildbot/win32-comm-1.9.2-check/build/objdir/mozilla/_tests/xpcshell/test_import/unit/test_winmail.js | failed to match item 41: true ||| [ProfD]News/testmsnews.microsoft.com - See following stack:
Attachment #442939 - Flags: approval-thunderbird3.1.10+ → approval-thunderbird3.1.10-
You need to log in before you can comment on or make changes to this bug.