561460 - test_csputils.js is broken

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Brandon Sterne (:bsterne)]

s: moz2-linux-slave28
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/content/unit/test_csputils.js | test failed (with xpcshell return code: 0), see following log:
Bug 560197 - [xpcshell-tests] Intermittent timeout after test_csputils.js, when running test_error_codes.js
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/content/unit/test_csputils.js | null == com - See following stack:

This appears to be a regression from:
http://hg.mozilla.org/mozilla-central/rev/426165b08c0c

Comment 1

[Brandon Sterne (:bsterne)]

Build log:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1272053448.1272054280.23504.gz

Comment 2

[Sid Stamm [:geekboy or :sstamm]]

This looks pretty straightforward based on the build log.

in test_csputils.js:

106     h = CSPHost.fromString("com");
107     do_check_eq(null, h); // "lone symbol should fail"

This should pass and not be null, since the host is parsed as "com" due to the check-in of bug 524066:

107     do_check_neq(null, h); // "lone symbol should not fail"

This one-character change should fix the bustage.

Comment 3

[Legacy TBPL/Treeherder Robot]

[e-mail]
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1272057758.1272058960.4087.gz
WINNT 5.2 mozilla-central opt test xpcshell, Started 14:22, finished 14:43

s: mw32-ix-slave04
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-opt-unittest-xpcshell\build\xpcshell\tests\content\unit\test_csputils.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-opt-unittest-xpcshell/build/xpcshell/tests/content/unit/test_csputils.js | null == com - See following stack:

Comment 4

[Brandon Sterne (:bsterne)]

Attachment: fix

Comment 5

[Brandon Sterne (:bsterne)]

I tested the fix and the test passes now.

Comment 6

[Brandon Sterne (:bsterne)]

http://hg.mozilla.org/mozilla-central/rev/85b315d1f708

Comment 7

[Martijn Wargers (dead)]

Is this bug fixed then?