561480 - Errors when loading WeaveCrypto.js on older platforms

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Until we transition over entirely to the js-ctypes flavor of WeaveCrypto, Weave will currently load both the binary and WeaveCrypto.js components, and pick between them at runtime.

This works fine, except that on pre-1.9.3 platforms this causes some harmless (?) error console noise, because WeaveCrypto.js can't import Services.jsm and jsctypes.jsm, which are new in 1.9.3.

This patch defers loading these modules until after a platform version check.

Comment 1

[Ed Lee :Mardak]

So this will leave a registered component that does nothing? Or it'll fail to do stuff when its interfaces are poked?

Comment 2

[Ed Lee :Mardak]

Hrm yeah,

Components.classes["@labs.mozilla.com/Weave/Crypto;2"].getService(Components.interfaces.IWeaveCrypto).generateRandomIV()

Error: uncaught exception: [Exception... "'[JavaScript Error: "Services is not defined" {file: "file:///Users/Ed/weave/dist/stage/components/WeaveCrypto.js" line: 109}]' when calling method: [IWeaveCrypto::generateRandomIV]"

Comment 3

[Ed Lee :Mardak]

Yeah, perhaps component = [WeaveCrypto] should just be [] if something fails.

Comment 4

[Justin Dolske [:Dolske]]

It's a component that only works on 1.9.3, no one should be invoking it on 1.9.2. This is just an interm fix until Weave only supports 1.9.3+, at which point it can be reverted.

Comment 5

[Ed Lee :Mardak]

Bug 561005 was going to check for existence of ;2 and load ;1 instead of doing the appinfo lookup everywhere.

let components = [];
try {
  Cu.import(..)
  components.push(WeaveCrypto);
}
catch(ex) {} ?

Comment 6

[Ed Lee :Mardak]

Attachment: v2

Comment 7

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/9396b591a8db
Only register WeaveCrypto if it was able to import scripts.