561490 - Test Pilot databases should use asynchronous API for reads/writes

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect, P1)

Description

[Jono Xia]

See documentation here: https://developer.mozilla.org/en/Storage#Asynchronously

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: Patch for this bug

* async-write-and-read.diff - for the XPI
* tab-switch-study.diff - the tab_switch_study.diff
* tab_switch_study.js - modified tab_switch_study.js

Comment 2

[Jono Xia]

Why does the study need to be modified?

Comment 3

[Jono Xia]

oh, because reading the database with the asynchronous API requires a callback.  I see.

Comment 4

[Jono Xia]

I'm going to hold off on merging this patch for now, because we're about to release a new study today, and changing the API that the studies use to write data (meaning the study would have to be incompatible with the older version of the extension, or incompatible with the newer) would not be a good thing to do at this time.  I'll revisit this after the toolbar study is done.

Comment 5

[Jono Xia]

Merged into extension in http://hg.mozilla.org/labs/testpilot/rev/8a3521afff3f