Closed Bug 561491 Opened 12 years ago Closed 5 months ago

Dromaeo DOM Events (Prototype) and DOM Event (jQuery) tests don't seem to trace well

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal
50

Tracking

()

RESOLVED INVALID
Tracking Status
platform-rel --- +

People

(Reporter: smaug, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [platform-rel-jQuery])

While profiling Dromaeo, I noticed that the DOM Events tests don't
actually seem to test DOM event handling, because JS code doesn't run
fast there.
Shark shows rather deep recursion of js_fun_call/js_Interpret/js_fun_apply
and if I read that all correctly, tracing doesn't work there.
(I was told that nested js_Interpret calls pretty much disable tracing)

The actual event handling takes just few % in the test.
Shaver tells me that Jason has been working on a fix for the deep bail problem.
I assume this is a tracking bug?  Bug 532696 and its dependencies cover the things I saw on the prototype tests last time I looked at them.  We probably need to look at the abort logs and trace exit logs for jquery too.  Smaug, were you going to do that?
Depends on: 532696
I don't know how to look at abort logs or trace exits, but probably
time to learn that.
> I don't know how to look at abort logs or trace exits

Catch me on irc or e-mail and we can talk?  Would love to have another DOM person looking at that sort of stuff.  ;)
Blocks: 562785
bz/smaug, is this bug still a valid non-TM bug or has DOM perf work moved on to other bugs at this point?
Would need to redo the profile from comment 0 to tell.  Olli, can you do that, or should I?
I could re-profile.
Blocks: 928318
Based on Bug 928318 the situation hasn't really improved.
Assignee: general → nobody
Whiteboard: [platform-rel-jQuery]
platform-rel: --- → ?
platform-rel: ? → +
Rank: 50

Old TM bug, no longer valid.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.