561491 - Dromaeo DOM Events (Prototype) and DOM Event (jQuery) tests don't seem to trace well

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

While profiling Dromaeo, I noticed that the DOM Events tests don't
actually seem to test DOM event handling, because JS code doesn't run
fast there.
Shark shows rather deep recursion of js_fun_call/js_Interpret/js_fun_apply
and if I read that all correctly, tracing doesn't work there.
(I was told that nested js_Interpret calls pretty much disable tracing)

The actual event handling takes just few % in the test.

Comment 1

[Johnny Stenback (:jst)]

Shaver tells me that Jason has been working on a fix for the deep bail problem.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I assume this is a tracking bug?  Bug 532696 and its dependencies cover the things I saw on the prototype tests last time I looked at them.  We probably need to look at the abort logs and trace exit logs for jquery too.  Smaug, were you going to do that?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

I don't know how to look at abort logs or trace exits, but probably
time to learn that.

Comment 4

[Boris Zbarsky [:bzbarsky]]

> I don't know how to look at abort logs or trace exits

Catch me on irc or e-mail and we can talk?  Would love to have another DOM person looking at that sort of stuff.  ;)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

bz/smaug, is this bug still a valid non-TM bug or has DOM perf work moved on to other bugs at this point?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Would need to redo the profile from comment 0 to tell.  Olli, can you do that, or should I?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

I could re-profile.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Based on Bug 928318 the situation hasn't really improved.

Comment 9

[André Bargull [:anba]]

Old TM bug, no longer valid.