561528 - browser_sanitize-timespans.js: |new Date().getMinutes()| usage issue

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Serge Gautherie (:sgautherie)]

Bug 467997 comment 10:
{
Johnathan Nightingale [:johnath]      2010-04-20 07:25:03 PDT

I notice that this test contains the
line:

var minutesSinceMidnight = new Date().getMinutes();

with minutesSinceMidnight used as a guard around various tests. (c.f.
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/browser_sanitize-timespans.js#14
and then
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/browser_sanitize-timespans.js#182
)

new Date().getMinutes() returns minutes since the top of the hour, not since
midnight, so all the if blocks testing for minutes > 60 will permanently fail,
which means we're not running those tests.
}

Comment 1

[Josh Matthews [:jdm]]

Attachment: Patch

Simple fix that makes an extra six tests run (and pass!) at 3:45am on my local machine.

Comment 2

[Josh Matthews [:jdm]]

http://hg.mozilla.org/mozilla-central/rev/e02d8d0d05e4