Last Comment Bug 561580 - @media {} should be invalid (i.e., @media rules don't allow empty media lists)
: @media {} should be invalid (i.e., @media rules don't allow empty media lists)
Status: RESOLVED INVALID
: css3
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: P3 normal (vote)
: mozilla1.9.3a5
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-24 13:39 PDT by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2010-05-06 15:50 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (3.18 KB, patch)
2010-04-24 17:35 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
Details | Diff | Splinter Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2010-04-24 13:39:39 PDT
In http://lists.w3.org/Archives/Public/www-style/2009Aug/0128.html the CSS working group resolved that @media rules should not allow empty media lists.  I wrote a patch for it immediately, but never got around to filing a bug.

(The minutes aren't all that clear, but the discussion was clear that the change was specific to @media and not a general media queries change.)

(I'll attach the patch once it passes try server; it requires at least one unit test adjustment and maybe more.)
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2010-04-24 17:35:10 PDT
Created attachment 441318 [details] [diff] [review]
patch

Passes all unit tests on try on Linux and Mac.  Still waiting for Windows results, but no reason to think they'll be different.
Comment 2 Boris Zbarsky [:bz] 2010-04-26 07:10:17 PDT
Comment on attachment 441318 [details] [diff] [review]
patch

r=bzbarsky
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2010-05-06 15:50:58 PDT
The CSS working group decided at yesterday's telecon that it should be valid after all.  So this is now invalid.

Note You need to log in before you can comment on or make changes to this bug.