Closed Bug 56161 Opened 24 years ago Closed 24 years ago

PSM-glue depends on profile which is evil.

Categories

(Core Graveyard :: Security: UI, defect, P3)

Product:
Core Graveyard
Component:
Security: UI
Version:
1.0 Branch
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

(Keywords: embed, verifyme)

Attachments

(1 file)

Remove profile depend.
1.26 KB, patch
Details | Diff | Splinter Review 
PSM-glue does not need the profile interface to be implemented to work.  Right
now, this requirement breaks embedder which do not have a concept of profile. 
The fix is trival
As a temporary workaround, psm-glue could always pass "mozilla" as the profile 
name and continue to pass the correct data directory.

    
  
Severity: normal → blocker
Keywords: embed, 
          
            rtm

    
    

    
  
look at the diff.  we just have to check for the profile implementation via
xpcom, and not return an error if it is not there.


    
    

    
  
Made my comment before I saw the diff.

Diff looks good.  r=javi

    
    

    
  
sr=mscott


    
    

    
  
Fixed in trunk.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED

    
    

    
  
Adding verifyme keyword.
Keywords: verifyme

    
  
QA Contact: nitinp → junruh

    
    

    
  
Verified based upon dougt's comments.
Status: RESOLVED → VERIFIED

    
    

    
  
Mass changing Security:Crypto to PSM
Component: Security: Crypto → Client Library
Product: Browser → PSM
Version: other → 2.1

    
    

    
  
Mass changing Security:Crypto to PSM

    
  
Product: PSM → Core

    
  
Version: psm2.1 → 1.0 Branch
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: