Closed
Bug 561878
Opened 14 years ago
Closed 14 years ago
xpinstall.enabled isn't properly blocking installation by webpages
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Whiteboard: [rewrite])
Attachments
(2 files)
|
941 bytes,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
|
1.75 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
When xpinstall.enabled is false it is just treated as if the webpage isn't allowed to install and a notification bar is displayed. This fixes that by not creating the installs if completely disabled.
Attachment #441624 -
Flags: review?(robert.bugzilla)
|
Assignee | |
Comment 1•14 years ago
|
||
Fixed by http://hg.mozilla.org/projects/addonsmgr/rev/74b9ef86dc84 and http://hg.mozilla.org/projects/addonsmgr/rev/c13f1f5f5a55
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
|
||
Comment 2•14 years ago
|
||
Comment on attachment 441624 [details] [diff] [review] patch rev 1 I'll leave it up to you but perhaps a browser test for this would be a good thing
Attachment #441624 -
Flags: review?(robert.bugzilla) → review+
|
|
||
Updated•14 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
|
||
Comment 3•14 years ago
|
||
Dave, can we completely cover it by an automated test?
Flags: in-testsuite?
Flags: in-litmus?
|
|
Assignee | |
Comment 4•14 years ago
|
||
I was actually catching this in tests already, but only when running a full test suite, this makes a single test fail for it.
Attachment #441840 -
Flags: review?(robert.bugzilla)
|
|
||
Updated•14 years ago
|
Attachment #441840 -
Flags: review?(robert.bugzilla) → review+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-landing]
|
|
Assignee | |
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8db3121bca07
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite?
Flags: in-testsuite+
Flags: in-litmus?
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
|
|
||
Comment 6•14 years ago
|
||
Verified fixed by the check-in and passing automated tests.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•