561880 - Passphrase doesn't accept unicode characters

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Firefox Home, defect)

Description

[Alex Limi (:limi) — Firefox UX Team]

To reproduce:

1. Set up a Weave account on your desktop, make sure the passphrase has some unicode characters in it (try the Norwegian characters "ÆØÅ")
2. Verify that you can log in and sync between desktop clients with the unicode passphrase
3. Try logging in on the iPhone client, it says "invalid passphrase". (hold in the A and O keys on the keyboard to access the special characters when entering the passphrase on the iPhone)

Comment 1

[Ragavan S [:rags]]

The iPhone client has been fixed, but depends on 1.3 server. This was a bug with the 1.2 server.

Comment 2

[Dan Walkowski]

This should be fixed as of the shipping of Firefox Sync 1.3.  It needs to be verified.

Comment 3

[Tony Chung [:tchung]]

i'm reopening this cause its broken for me.  tested against beta 12 against the sync 1.3.1 server.  I've tried changing my password and secret phrase to: "silverØrÅnge",  and it works fine on desktop login.  but when i switch to itouch, it fails to authenticate.

Comment 4

[Ragavan S [:rags]]

(In reply to comment #3)
> i'm reopening this cause its broken for me.  tested against beta 12 against the
> sync 1.3.1 server.  I've tried changing my password and secret phrase to:
> "silverØrÅnge",  and it works fine on desktop login.  but when i switch to
> itouch, it fails to authenticate.

Is this a regression in the iPhone app then? Tony - sounds like it works fine for you with Sync on desktop, right?

Comment 5

[Tony Chung [:tchung]]

yep, i'm just reporting that it works across desktop builds (mac 3.6.4 to win7 3.6.4 on weave 1.3.1), but not from mac to my itouch.  My itouch keeps erring out saying the password is incorrect.  (i used step 3 in comment 1 to reproduce the Ø and Å characters.)

Comment 6

[Tony Chung [:tchung]]

flagging as blocker since it works on desktop client and server

Comment 7

[Ragavan S [:rags]]

(In reply to comment #6)
> flagging as blocker since it works on desktop client and server

Curious how this works on desktop as it appears to be a bug on the server? See bug# 573115 for details.

Comment 8

[Zandr Milewski [:zandr]]

> (In reply to comment #6)
> > flagging as blocker since it works on desktop client and server
> 
> Curious how this works on desktop as it appears to be a bug on the server? See
> bug# 573115 for details.

This is not the same as bug# 573115

That bug affects passwords that have a special character at the end of the password *only*. special characters in the middle of the password, as :tchung noted, work fine on the desktop.(In reply to comment #7)

Comment 9

[Zandr Milewski [:zandr]]

(In reply to comment #8)
> That bug affects passwords that have a special character at the end of the
> password *only*. special characters in the middle of the password, as :tchung
> noted, work fine on the desktop.(In reply to comment #7)

Also, this appears to be about the secret phrase, not the password.

Comment 10

[Ragavan S [:rags]]

This needs to be fixed on the desktop client because the iPhone client is doing the right thing here.

We won't block on this for 1.0, but it does mean we will have to relnote this and make the app available only in english speaking countries until the desktop client bug is fixed.

Comment 11

[Philipp von Weitershausen [:philikon]]

With bug 558963 fixed, Firefox Sync will UTF-8 encode the passphrase and no longer cut the high unicode bytes off. This fix will be in 1.4.1 and 1.5.

I've verified that the iPhone client can properly decode data encrypted with a unicode passphrase by Firefox Sync with those fixes applied. I tested this with umlauts, we might also want to test Chinese characters, etc.

Comment 12

[Philipp von Weitershausen [:philikon]]

Tony has confirmed that the iPhone client now accepts unicode passphrases entered on the desktop.

Comment 13

[Tony Chung [:tchung]]

Verified fix with sync 1.4.1b2 against FF Home beta.   secret passphrase on FF Home picks up UTF8 (tested with chinese also)

Comment 14

[Tony Chung [:tchung]]

Moving FFHome-related bugs to new component -> Firefox Home