[k] Remove "Did you mean:" spelling-suggestion functionality from Kitsune search

VERIFIED FIXED in 2.0

Status

support.mozilla.org
Search
--
major
VERIFIED FIXED
8 years ago
7 years ago

People

(Reporter: stephend, Assigned: jsocol)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-], URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Not trying to steal James's thunder (really!), but he said in #sumodev today that we'll be removing the spelling-suggestions functionality prior to shipping Kitsune 2.0.

This here be that thar bug which tracks its removal, thus, obviating bug 550103 and bug 549474?
(Assignee)

Updated

8 years ago
Assignee: nobody → james
(Assignee)

Comment 1

8 years ago
Paul: r? http://github.com/jsocol/kitsune/commit/cb930318a7085ae1cf15f04e752b1bd946dd00cd
r+
Looking at this, we'll still require the packages relevant to suggestions, just not call them. I don't think installing those packages would cause issues for IT, but just bringing it up, to be aware.
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> Looking at this, we'll still require the packages relevant to suggestions, just
> not call them. I don't think installing those packages would cause issues for
> IT, but just bringing it up, to be aware.

I'd like to get this running eventually, we just don't have time to debug it right now. I didn't remove the requirements, because that would also require removing the helpers and tests that depend on them.
(Assignee)

Comment 4

8 years ago
http://github.com/jsocol/kitsune/commit/cb930318a7085ae1cf15f04e752b1bd946dd00cd

Merged and pushed.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Updated

8 years ago
Whiteboard: [qa-]
(Reporter)

Comment 5

7 years ago
Verified FIXED on http://support.mozilla.com/en-US/search?fx=1&os=1&q=firfox
Status: RESOLVED → VERIFIED
(Reporter)

Comment 6

7 years ago
Created attachment 533074 [details]
Post-fix screenshot
You need to log in before you can comment on or make changes to this bug.