Closed
Bug 562029
Opened 15 years ago
Closed 15 years ago
ipc fails to build with gcc version 4.1.2
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: stransky, Assigned: stransky)
Details
Attachments
(1 file, 1 obsolete file)
2.48 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
Firefox fails to build with an old gcc because of the visibility conflicts. /ipc is compiled with visibility(default), rest of the tree is build with visibility(hidden).
Global symbols from ipc are built as R_X86_64_PC32 so the final link of libxul.so fails.
I tried to build /ipc with system wrappers&visibility(hidden) but there are still missing wrappers for STL. Do you accept a patch where the STL headers are enclosed by #pragma visibility(default) or we may find some better solution?
Assignee | ||
Comment 1•15 years ago
|
||
Seems to be related to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19664
new gcc wraps STL headers by #pragma GCC visibility push(default)/#pragma GCC visibility pop.
Comment 2•15 years ago
|
||
I thin it is dup to one of these bugs...
https://bugzilla.mozilla.org/show_bug.cgi?id=561408
https://bugzilla.mozilla.org/show_bug.cgi?id=560935
Assignee | ||
Comment 3•15 years ago
|
||
I don't think so...we're missing some STL headers in system_wrappers. I'm working on a patch for it.
Assignee | ||
Comment 4•15 years ago
|
||
Assignee | ||
Comment 5•15 years ago
|
||
Comment on attachment 442076 [details] [diff] [review]
builds ipc with hidden visibility by default
Can you please check this one?
Attachment #442076 -
Flags: review?(benjamin)
Updated•15 years ago
|
Attachment #442076 -
Flags: review?(benjamin) → review?(jones.chris.g)
Comment on attachment 442076 [details] [diff] [review]
builds ipc with hidden visibility by default
Builds fine for me on gcc 4.4 as well.
Attachment #442076 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 7•15 years ago
|
||
Assignee: nobody → stransky
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Comment 8•15 years ago
|
||
backed out
s: mv-moz2-linux-ix-slave07
TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
make[1]: *** [check] Error 1
make: *** [check] Error 2
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1273765393.1273766274.8999.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•15 years ago
|
||
synchronized config/system-headers & js/src/config/system-headers
Attachment #442076 -
Attachment is obsolete: true
Attachment #445372 -
Flags: review?(jones.chris.g)
Assignee | ||
Updated•15 years ago
|
Status: REOPENED → ASSIGNED
Assignee | ||
Updated•15 years ago
|
Attachment #445372 -
Attachment is patch: true
Attachment #445372 -
Attachment mime type: application/octet-stream → text/plain
Comment on attachment 445372 [details] [diff] [review]
sync with js/src/config
Looks OK to me, although I don't understand the apparent patching against .orig files.
Attachment #445372 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 15 years ago → 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Comment 12•15 years ago
|
||
Does this need to land on branches?
Assignee | ||
Comment 13•15 years ago
|
||
Would be great to have it in 1.9.2, we ship 3.6.x on some systems with old gcc like RHEL-5.
You need to log in
before you can comment on or make changes to this bug.
Description
•