562029 - ipc fails to build with gcc version 4.1.2

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Firefox fails to build with an old gcc because of the visibility conflicts. /ipc is compiled with visibility(default), rest of the tree is build with visibility(hidden). 

Global symbols from ipc are built as R_X86_64_PC32 so the final link of libxul.so fails.

I tried to build /ipc with system wrappers&visibility(hidden) but there are still missing wrappers for STL. Do you accept a patch where the STL headers are enclosed by #pragma visibility(default) or we may find some better solution?

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Seems to be related to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19664
new gcc wraps STL headers by #pragma GCC visibility push(default)/#pragma GCC visibility pop.

Comment 2

[Oleg Romashin (:romaxa)]

I thin it is dup to one of these bugs...
https://bugzilla.mozilla.org/show_bug.cgi?id=561408
https://bugzilla.mozilla.org/show_bug.cgi?id=560935

Comment 3

[Martin Stránský [:stransky] (ni? me)]

I don't think so...we're missing some STL headers in system_wrappers. I'm working on a patch for it.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: builds ipc with hidden visibility by default

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 442076 [details] [diff] [review]
builds ipc with hidden visibility by default

Can you please check this one?

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 442076 [details] [diff] [review]
builds ipc with hidden visibility by default

Builds fine for me on gcc 4.4 as well.

Comment 7

[Dão Gottwald [::dao]]

http://hg.mozilla.org/mozilla-central/rev/48e202424e35

Comment 8

[Dão Gottwald [::dao]]

backed out

s: mv-moz2-linux-ix-slave07
TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
make[1]: *** [check] Error 1
make: *** [check] Error 2

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1273765393.1273766274.8999.gz

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: sync with js/src/config

synchronized config/system-headers & js/src/config/system-headers

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 445372 [details] [diff] [review]
sync with js/src/config

Looks OK to me, although I don't understand the apparent patching against .orig files.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/474b37dfdfb7

Comment 12

[Benjamin Smedberg]

Does this need to land on branches?

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Would be great to have it in 1.9.2, we ship 3.6.x on some systems with old gcc like RHEL-5.