Closed Bug 562101 Opened 15 years ago Closed 15 years ago

XMLParser omits the last char of a DOCTYPE node

Categories

(Tamarin Graveyard :: Virtual Machine, defect, P2)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
flash10.1

People

(Reporter: stejohns, Assigned: stejohns)

Details

Attachments

(2 files)

Patch
459 bytes, patch
wsharp
: review+
Details | Diff | Splinter Review
selftest
2.68 KB, patch
stejohns
: review+
Details | Diff | Splinter Review
This is trivial to fix, but annoyingly, a testcase can't be written in AS3/E4X, as these nodes are parsed-and-discarded and aren't accessible to E4X parsing. (We test that it is well-formed, but we return the wrong text value.) Flash/AIR, on the other hand, leverage the same code but look at these nodes, so we should probably add some way to test all of them.
Attached patch Patch — — Splinter Review
Assignee: nobody → stejohns
Attachment #441858 - Flags: review?(wsharp)
Attachment #441858 - Flags: review?(wsharp) → review+
http://asteam.macromedia.com/hg/tamarin-redux-argo/rev/45c29866e814 Leaving open for now until we figure out the best way to implement a testcase. (Selftests perhaps?)
Flags: flashplayer-qrb+
Priority: -- → P2
Target Milestone: --- → flash10.1
Whiteboard: needs-testcase
Flags: in-testsuite?
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attached patch selftest — — Splinter Review
Attachment #445711 - Flags: review?(stejohns)
Flags: flashplayer-triage+
QA Contact: vm → brbaker
Attachment #445711 - Flags: review?(stejohns) → review+
Pushed to tr-argo -> 4037:cc22bf69f7cc
Status: RESOLVED → VERIFIED
Flags: in-testsuite? → in-testsuite+
Whiteboard: needs-testcase
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: