TM: make DTrace hooks pretty

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: cdleary, Assigned: cdleary)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 2 obsolete attachments)

People seem unhappy with the amount of space that the dtrace hooks take up. I'd like to demonstrate that these hooks can be non-obtrusive and very useful, so I'm volunteering for another cleanup patch.
Created attachment 441928 [details] [diff] [review]
Prettify obtrusive DTrace stuff.

Leaves old interface in place for now.
Attachment #441928 - Flags: review?(sayrer)

Comment 2

8 years ago
Comment on attachment 441928 [details] [diff] [review]
Prettify obtrusive DTrace stuff.

this is a good first step, if we add systemtap or some windows probes, we should change the DTrace:: lines in the VM to Probe:: and allow different impls.
Attachment #441928 - Flags: review?(sayrer) → review+
Created attachment 442862 [details] [diff] [review]
Prettify DTrace probes.

Patch update against trunk.
Attachment #441928 - Attachment is obsolete: true
Created attachment 442869 [details] [diff] [review]
Arguments deletion fix and tests.

Whoops. For real this time.
Attachment #442862 - Attachment is obsolete: true
Whiteboard: fixed-i
http://hg.mozilla.org/tracemonkey/rev/12049657ec65
Whiteboard: fixed-i → fixed-in-tracemonkey

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/12049657ec65
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Hmm. I'm getting build failures on my 10.6 box with DTrace enabled...

Undefined symbols:
  "_jsdtrace_execute_done", referenced from:
      js::DTrace::ExecutionScope::endExecution()     in jsinvoke.o
  "_jsdtrace_object_finalize", referenced from:
      js::DTrace::finalizeObject(JSObject const*)in jsgc.o
  "_jsdtrace_function_return", referenced from:
      js::DTrace::exitJSFun(JSContext*, JSStackFrame*, JSFunction const*, long, long*)in jsinterp.o
      ...etc etc...
(In reply to comment #7)
> Hmm. I'm getting build failures on my 10.6 box with DTrace enabled...

I see it too... should have a fix for this soon.
You need to log in before you can comment on or make changes to this bug.