562163 - Cannot delete the last tag associated with an add-on

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: selection source for tags

steps to reproduce:
1.Go to the detail page for an add-on.(https://preview.addons.mozilla.org/en-US/firefox/addon/2410/)
2.Add two tags(test,testing)
3.Delete one of them
4.Hover on the remaining tag

expected result:
On hover, a red cross mark appears,allowing the user to delete the tag they created.

actual result:
If there is only tag still associated with that add-on,the red cross mark does NOT appear.

reproducible:most of the times

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Probably a cache issue with AMO tags for addons being cached, and remora not invalidating:

http://github.com/jbalogh/zamboni/commits/b5c2036

Comment 2

[krupa raj[:krupa]]

I can still reproduce this problem-
http://screencast.com/t/MjIzODJiYzc

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

I see your specific case here, but I can't consistently reproduce it - and locally I never run into this issue.

Part of the problem is the underlying layer is served by remora and we've had to adjust zamboni HTML to be valid - while remora sends us stuff that breaks us.

I'd push to move this to 5.11 making this dependent on tags.  The tags functionality seems passable for other addons - and isn't too heavily used to block 5.10.

Comment 4

[Wil Clouser [:clouserw]]

Ummmmm.....that's weird.  If you go back to that page now does the red x appear?  If not, it could be removing the person as an author or something when it's saving the other one?  If it's a caching thing it should be expired by now.

Is this present on the current production site?

Comment 5

[krupa raj[:krupa]]

I can consistently reproduce this bug with these steps:

1.Add a tag to an add-on
2.Navigate away from that page(go to AMO homepage)
3.Go back to the add-on detail page
4.Now,try to delete that tag

You won't see the red cross to delete the tag.However after step#4,if you add another tag,then you see the cross mark to delete both tags.

This does not happen in prod.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Okay, this isn't just the last tag, it seems to be any tag.  I can reproduce, which means I can fix it.

Comment 7

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Justin/Chowse,

Need some design ideas.

Let's assume a popular addon (E.g. adblock plus).

Let's say it has tags from users:

ad ad ads foo bar

so we'd display:

ad
ads
foo
bar

If I was one of the two people to tag this addon as "ad."  In theory a red x will show up.  The page will reload and internally we'll know we have the following tags:

ad ads foo bar

and display:

ad
ads
foo
bar

same as before -- confusing user behavior.

It might be nice to indicate which tags are your tags and which aren't.  We could use a different icon, or split them up in the display... e.g:

Your Tags:
ad

Everyones Tags:
ad
ads
foo
bar

or optionally omit your tags from Everyones Tags.

I prefer splitting them as it's more obvious that 1. which tags I *can* delete and 2. that if I delete a tag, it may still be present, but at least not under *my* tags.

Thanks,

-d

Comment 8

[Wil Clouser [:clouserw]]

I don't think design changes should block this bug.  Can you fix the current behavior?

Comment 9

[Chris Howse [:chowse]]

(In reply to comment #7)
(Just noting this, even if it's not blocking.)
I like the idea of splitting out your own tags. Tags you created could appear at the top of the list with an orange/red icon (which we have from FamFamFam). If the author or a different user has used the same tag, it should also show up under that respective tag group. That should eliminate any confusion described above.

Comment 10

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commits/159bfd4

Comment 11

[krupa raj[:krupa]]

I can now delete the last tag associated with an add-on.Filed a new bug to track comment #7