Last update date for plugins always shows 'Unknown'

VERIFIED FIXED in mozilla2.0b2

Status

()

defect
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: whimboo, Assigned: mossop)

Tracking

Trunk
mozilla2.0b2
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [rewrite])

Attachments

(1 attachment)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100415 Minefield/3.7a5pre (.NET CLR 3.5.30729)

Looks like we do not have a way to retrieve the last update time for a specific plugin? If that's the case we should remove this entry for the plugins digest view.
Agreed that its pretty useless in that case. But I'm not sure about special-casing plugins, of whether it should never show anything if the last update date is not known (regardless of addon type). 

Boriss - thoughts?
Keywords: uiwanted
We can get the modification time of the plugin's file which might be helpful
(In reply to comment #2)
> We can get the modification time of the plugin's file which might be helpful

Oh, yes please.
In the general case though I'd say if a provider doesn't give an updateDate then we should just hide the UI for that
Blocks: 554007
No longer blocks: 554007
(In reply to comment #2)
> We can get the modification time of the plugin's file which might be helpful

That would be awesome if it's possible

(In reply to comment #4)
> In the general case though I'd say if a provider doesn't give an updateDate
> then we should just hide the UI for that

Yeah, sounds good.  We should also move add-ons with an unknown update date to the bottom of the list (oldest) when they are sorted by last date updated
Keywords: uiwanted
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Posted patch patch rev 1Splinter Review
This implements installDate and updateDate for the plugin wrappers.
Attachment #454623 - Flags: review?(robert.bugzilla)
Comment on attachment 454623 [details] [diff] [review]
patch rev 1

>diff --git a/toolkit/mozapps/extensions/PluginProvider.jsm b/toolkit/mozapps/extensions/PluginProvider.jsm
>--- a/toolkit/mozapps/extensions/PluginProvider.jsm
>+++ b/toolkit/mozapps/extensions/PluginProvider.jsm
>@@ -226,16 +226,26 @@ function PluginWrapper(aId, aName, aDesc
>     let file = Cc["@mozilla.org/file/local;1"].createInstance(Ci.nsILocalFile);
>     aTags.forEach(function(aTag) {
>       file.initWithPath(aTag.fullpath);
>       size += getFileSize(file);
>     });
>     return size;
>   });
> 
>+  this.__defineGetter__("installDate", function() {
>+    let date = 0;
Might be better to initialize this to Date.now() though this way if there is a problem it will be immediately obvious.
Attachment #454623 - Flags: review?(robert.bugzilla) → review+
Landed: http://hg.mozilla.org/mozilla-central/rev/47db0d7433e8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3b2
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; en-US; rv:2.0b2pre) Gecko/20100718 Minefield/4.0b2pre

Marking as in-testsuite+ because there is a test for. No manual test necessary.
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.