De-nsIDOM* nsIContentSerializer methods

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
5 months ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

(Blocks 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

To reduce nsIDOM* usage in nsDocumentEncoder, also serializers need to be
de-nsIDOM'ed.
Posted patch wip (obsolete) — Splinter Review
Comment on attachment 442117 [details] [diff] [review]
wip

DocumentEncoder patch and this one speed up 
https://bugzilla.mozilla.org/attachment.cgi?id=442087
~20%
Attachment #442117 - Flags: review?(jonas)
Comment on attachment 442117 [details] [diff] [review]
wip

I need to update this for Bug 561221
Attachment #442117 - Flags: review?(jonas)
Attachment #442117 - Flags: review?(jonas)
Comment on attachment 442117 [details] [diff] [review]
wip

Why I didn't ask a review for this?
Would you mind updating this to do the new isElement stuff that bz added before I review this? Might as well review after those changes are done.
Posted patch patchSplinter Review
Attachment #442117 - Attachment is obsolete: true
Attachment #443001 - Flags: review?(jonas)
Attachment #442117 - Flags: review?(jonas)
Comment on attachment 443001 [details] [diff] [review]
patch

There are a bunch of places where you could replace static_cast to nsIContent* with calls to AsElement().

r=me either way
Attachment #443001 - Flags: review?(jonas) → review+
Oops, the patch somehow caused some orange.
Posted patch +fixSplinter Review
Ok, it was just a silly copy-paste error.
http://hg.mozilla.org/mozilla-central/rev/764614e8e92f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.