Closed
Bug 562321
Opened 16 years ago
Closed 16 years ago
De-nsIDOM* nsIContentSerializer methods
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
|
56.93 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
|
56.93 KB,
patch
|
Details | Diff | Splinter Review |
To reduce nsIDOM* usage in nsDocumentEncoder, also serializers need to be
de-nsIDOM'ed.
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Comment 2•16 years ago
|
||
Comment on attachment 442117 [details] [diff] [review]
wip
DocumentEncoder patch and this one speed up
https://bugzilla.mozilla.org/attachment.cgi?id=442087
~20%
Attachment #442117 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 3•16 years ago
|
||
Attachment #442117 -
Flags: review?(jonas)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #442117 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 4•16 years ago
|
||
Comment on attachment 442117 [details] [diff] [review]
wip
Why I didn't ask a review for this?
Would you mind updating this to do the new isElement stuff that bz added before I review this? Might as well review after those changes are done.
|
|
Assignee | |
Comment 6•16 years ago
|
||
Attachment #442117 -
Attachment is obsolete: true
Attachment #443001 -
Flags: review?(jonas)
Attachment #442117 -
Flags: review?(jonas)
Comment on attachment 443001 [details] [diff] [review]
patch
There are a bunch of places where you could replace static_cast to nsIContent* with calls to AsElement().
r=me either way
Attachment #443001 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 8•16 years ago
|
||
Oops, the patch somehow caused some orange.
|
|
Assignee | |
Comment 9•16 years ago
|
||
Ok, it was just a silly copy-paste error.
|
|
Assignee | |
Comment 10•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•