562329 - importxml.pl shouldn't set the resolution to INVALID when a closed bug has none

Status: RESOLVED FIXED

(Bugzilla :: Bug Import/Export & Moving, defect)

Description

[Fabian Groffen]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en; rv:1.9.0.18) Gecko/2010021619 Camino/2.0.2 (like Firefox/3.0.18)
Build Identifier: Bugzilla-3.6

Use of uninitialized value $resolution in concatenation (.) or string at ./importxml.pl line 1027.

code:
1026           if(!$valid_res){
1027               $err .= "Unknown resolution \"$resolution\".\n";
1028               $err .= "   Setting resolution to MOVED\n";

Problem here is that the assumption is made that resolution is always set to something.  However, it is initialised to undef when not found in the input XML, and at various places undeffed at as well.  Hence a suggested fix:

           if(!$valid_res){
               if (defined $resolution) {
                   $err .= "Resolution value absent.\n";
               } else {
                   $err .= "Unknown resolution \"$resolution\".\n";
               }
               $err .= "   Setting resolution to MOVED\n";
               $resolution = "MOVED";
           }

The problem just results in a warning, nothing big really.

Reproducible: Always

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

If there is no resolution defined, then the bug is reopened and so we shouldn't set the resolution to INVALID.

Comment 2

[Frédéric Buclin]

Comment on attachment 528130 [details] [diff] [review]
patch, v1

mkanat said I didn't need review for this.

Comment 3

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified importxml.pl
Committed revision 7788.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified importxml.pl
Committed revision 7577.