562334 - Content not appearing correctly on Usmagazine.com

Status: VERIFIED FIXED

(Core :: Layout, defect, P1)

Description

[Chelsea Novak [:chelsea]]

str:
1)Go to usmagazine.com
2)notice missing content to right on main photo
3)hover over area with mouse notice links appear - same with photo on far right
4)scroll up and down, notice content disappears again

tested with 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a5pre) Gecko/20100427 Minefield/3.7a5pre

Comment 1

[Chelsea Novak [:chelsea]]

Attachment: not right

Comment 2

[Chelsea Novak [:chelsea]]

Attachment: right

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Works in Firefox 3.6.3, so looks like a recent trunk regression. Layers?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Hmm.  I don't see the problem, with the same exact build and OS as in comment 0.  Either in my usual browsing profile, or a clean profile.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't see it exactly as reported, but I do see problems.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

I believe this is problem from the cairo update. We screw up the clipping when drawing the object frame.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Attachment: A simplified test case

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

We didn't take that Cairo update on any of the branches, did we?

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Nope

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Attachment: Fix cairo_quartz_get_cg_context_with_clip

This problem happens when clip->all_clipped is set and we go to get a clipped context. Normally backends don't see operations with clip->all_clipped and so _cairo_surface_clipper_set_clip is designed with the assumption that clip->all_clipped is never true. I added a work-around by manually setting the CGContextClip with an empty rectangle, however this caused cairo to be confused about what the actual clip was.

This patch fixes the problem by adding a new function cairo_quartz_finish_cg_context_with_clip that is called after we're done with the native context. It moves the CGContextSave/RestoreGState calls out of gfxNativeDrawing into cairo and uses them to ensure that the clip remains consistent with cairo's model of them.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

I checked in a broken version of this last night.
It should be correct now:
http://hg.mozilla.org/mozilla-central/rev/31d4639e6857

Comment 13

[Alex]

The simplified test case still renders incorrectly in the current nightly (1e383909069b), zooming in and out causes different parts to render.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED for me, using:

Build identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100506 Minefield/3.7a5pre