revise dialog styling to match new context and site menus

RESOLVED FIXED

Status

Fennec Graveyard
General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: madhava, Assigned: vingtetun)

Tracking

Fennec 1.1
x86
Mac OS X

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

8 years ago
1.1 introduces some new styling for the site menu and context menus.  In comparison, some of our existing styling for modal dialogs (which we meant to replace ASAP anway) and selectbox assistant looks heavy and old.

first pass restyling, using 1.1 styles, for a modal dialog: http://mozilla.seanmartell.com/fennec/install-2.jpg
(Reporter)

Comment 1

8 years ago
(In reply to comment #0)
> first pass restyling, using 1.1 styles, for a modal dialog:
> http://mozilla.seanmartell.com/fennec/install-2.jpg

we should obviously stack the options, site-menu-style, when in portrait.
(Reporter)

Comment 2

8 years ago
for comparison, the current version: http://www.flickr.com/photos/madhava_work/4156036273/
Created attachment 442260 [details] [diff] [review]
wip v0.1

This wip change the alert/prompt/select to have the look and feel of Sean's mockup, it also change some sizing code of the prompt services to allow the dialogs to resize automatically depending on the size of the window.

It stays a few things that i'm not sure of:
 * do we want to stack the buttons as in the site menu? As an example if a have a dialog with 3 buttons (Ok, Cancel, Never) do we really want to stack them?
 * I've remove support for "closebutton" for now. Do we want it?

Screenshots will come.
Also:
 * winmo theme is not done
 * There is no support for an icon for now (like in the mockup, but it think we can see that later)
Created attachment 442295 [details] [diff] [review]
Patch v0.1
Created attachment 442296 [details]
screenshoots

Some screenshots of the look and feel of the alerts with the theme
Attachment #442260 - Attachment is obsolete: true

Comment 7

8 years ago
>  * I've remove support for "closebutton" for now. Do we want it?

It's not used by the prompt service, but it's there to avoid having to add a big "close/done/ok" button on simple informative dialogs. I know of some add-ons that use it.
(Reporter)

Comment 8

8 years ago
for a bit of scope creep, the new border styling would work well on a few other
UI elements:

http://www.flickr.com/photos/madhava_work/4562811537/sizes/o/
(Reporter)

Comment 9

8 years ago
(In reply to comment #6)
> Created an attachment (id=442296) [details]
> screenshoots
> 
> Some screenshots of the look and feel of the alerts with the theme

This is looking great!  The issue from the IRC discussion:

- more vertical space for the message in portrait (re: slow script dialog)
Created attachment 442436 [details] [diff] [review]
Patch

I've add back the support for closebutton, done the winmo theme and address madhava's comments.
Assignee: nobody → 21
Attachment #442295 - Attachment is obsolete: true
Attachment #442436 - Flags: review?(mark.finkle)
Attachment #442436 - Flags: review?(mark.finkle) → review+
Comment on attachment 442436 [details] [diff] [review]
Patch

Patch looks good and works well. Two comments:

* We should move the pageaction CSS out of browser.css and into platform.css - it's core. Could you file a followup bug.
* The checkbox UI still doesn't look as good as it could. Hopefully Madhava has some ideas for making it better.
pushed m-b:
http://hg.mozilla.org/mobile-browser/rev/69ceecfb8f2a

waiting to push to m-1.1 until it bakes on m-b a bit.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(In reply to comment #11)
> (From update of attachment 442436 [details] [diff] [review])
> Patch looks good and works well. Two comments:
> 
> * We should move the pageaction CSS out of browser.css and into platform.css -
> it's core. Could you file a followup bug.

filed bug 562904 for that
(Reporter)

Comment 14

8 years ago
(In reply to comment #8)
> for a bit of scope creep, the new border styling would work well on a few other
> UI elements:
> 
> http://www.flickr.com/photos/madhava_work/4562811537/sizes/o/

one more bit of scope creep -- we should do the same thing to the edges of the "page bookmarked" alert.
pushed to m-1.1:
http://hg.mozilla.org/releases/mobile-1.1/rev/15ec82a52bce
You need to log in before you can comment on or make changes to this bug.