562452 - Clicking the identity button when the location bar was focused shouldn't draw a focus ring

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Can you explain what this patch has to do with the summary? I.e., why is the "#identity-box:-moz-focusring" vs. "#identity-box:focus" distinction related to the location bar? What's the justification for removing ":not(:active):not([open="true"])" from pinstripe?

Comment 2

[Dão Gottwald [:dao]]

(In reply to comment #1)
> Can you explain what this patch has to do with the summary? I.e., why is the
> "#identity-box:-moz-focusring" vs. "#identity-box:focus" distinction related to
> the location bar?

The identity button is only focusable if the location bar has focus to start with. -moz-focusing omits the focus ring when clicking the button rather than tabbing to it.

> What's the justification for removing
> ":not(:active):not([open="true"])" from pinstripe?

It was a workaround for bug 418521.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

This patch doesn't seem to make a difference on Windows - with it applied, I still see a focus ring briefly when clicking the larry button while the location bar is focused. Am I missing something?

Comment 4

[Dão Gottwald [:dao]]

You probably activated focus rings for that window by pressing Tab.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Nope, that's not it. I tested again, making sure not to press tab, but I still see the behavior from comment 3.

Comment 6

[Dão Gottwald [:dao]]

Just tried it again and compared it with another trunk build -- the focus ring vanished as expected. http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-7cbd6a949364/tryserver-win32/firefox-3.7a5pre.en-US.win32.zip / http://hg.mozilla.org/try/rev/7cbd6a949364

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch

updated to tip

Comment 8

[Asaf Romano (gone)]

Comment on attachment 463889 [details] [diff] [review]
patch

r=mano

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/139e50f2d7a1