562476 - command line options are not specifiable in the mozmill.cli() function

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, enhancement)

Description

[Jeff Hammel]

mozmill.cli(), the command line entry-point for the `mozmill` script, neither takes nor transmits command line arguments.  This relies then on `optparse`'s behavior to parse sys.argv[1:].  This makes it uncallable as a python function.  Likewise, the mozmill.CLI class which it front-ends has no such facility.  Adding such a facility would make the command line entry point callable from python with mangling sys.argv

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

I'm not really sure if I understand this problem here. Jeff, could a possible fix on bug 564537 help you here?

Comment 2

[Jeff Hammel]

this is now fixed on master, closing

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Which changeset made it possible?

Comment 4

[Jeff Hammel]

Not sure, entirely?  It landed with pluggable-events + the command line refactor, so whatever changeset made it go from e.g.

def cli():
  CLI().run()

to

def cli(args=sys.argv[1:]):
  CLI(args).run()

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

It's always helpful to have the changeset listed in the bug for verification purposes. It's kinda hard at a later stage to identify a regression without that information.