Closed Bug 562487 Opened 16 years ago Closed 16 years ago

comparison between signed and unsigned integer expressions in BoxBlur and nsSVGFETileElement::Filter

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file, 1 obsolete file)

alternative
2.70 KB, patch
roc
: review+
Details | Diff | Splinter Review
In function ‘void BoxBlur nsSVGFilters.cpp:538: warning: comparison between signed and unsigned integer expressions nsSVGFilters.cpp:554: warning: comparison between signed and unsigned integer expressions nsSVGFilters.cpp:560: warning: comparison between signed and unsigned integer expressions In member function ‘virtual nsresult nsSVGFETileElement::Filter nsSVGFilters.cpp:2964: warning: comparison between signed and unsigned integer expressions nsSVGFilters.cpp:2967: warning: comparison between signed and unsigned integer expressions
Attached patch patch (obsolete) — — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #442215 - Flags: review?(roc)
Wouldn't it make more sense to make aLeftLobe and aRightLobe PRInt32?
Attached patch alternative — — Splinter Review
Attachment #442215 - Attachment is obsolete: true
Attachment #442226 - Flags: review?(roc)
Attachment #442215 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/17478c824e1b
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: