Closed Bug 562515 Opened 10 years ago Closed 10 years ago

Reset sync option "Replace all data on this computer with your Weave data" is not handling local deletes correctly

Categories

(Firefox :: Sync, defect, blocker)

defect
Not set
blocker

Tracking

()

VERIFIED FIXED

People

(Reporter: tracy, Assigned: Mardak)

Details

(Keywords: dataloss, Whiteboard: [weave1.3])

Attachments

(1 file)

Seen on 1.2.3 and 1.3.b2

STR:

0) with Weave data synced to cloud and client A ans client B synced to it...
1) remove a few bookmarks and/or other data from client A
2) In the account manager, Reset Sync
3) choose the option to: "Replace all data on this computer with your Weave data"
4) sync client B

tested results: 
after step 3) deleted items in step one remain gone
what's worse:
after step 4) those items area also deleted from client B

Expected results:
A restore of deleted items should occur on client A.
Overwrite local data from cloud should do nothing to the cloud data.

One of the most useful aspects of option 2 is to recover a local client from some hideous corruption.  With this bug, the corruption would be unknowingly propagated to other clients
Flags: blocking-weave1.3?
Whiteboard: [weave1.3]
OS: Mac OS X → All
Attached patch v1Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #443192 - Flags: review?(mconnor)
Attachment #443192 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/labs/weave/rev/4331211e64cf
Clear out any changed ids when wiping the client to prevent delete records from getting uploaded for these items.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: blocking-weave1.3? → blocking-weave1.3+
Resolution: --- → FIXED
Target Milestone: --- → 1.3b4
verified with 1.3b4
Status: RESOLVED → VERIFIED
in-litmus?  We have a smoke for general case but not a BFT for deletes
Flags: in-litmus?
Investigating this bug for being potential crossweave automation test case
candidate.
Flags: in-testsuite?
Added test for this as http://hg.mozilla.org/automation/crossweave/rev/05d1a3e547e1
Flags: in-testsuite? → in-testsuite+
removing in-litmus flag, it no longer exists
Flags: in-litmus?
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.