562525 - nsPropertiesParser::FinishValueState potentially uses a variable uninitialized dependent on a member of a class in a file with threadsafe classes

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[timeless]

Darwin timeless-mbp.local 10.3.0 Darwin Kernel Version 10.3.0: Fri Feb 26 11:58:09 PST 2010; root:xnu-1504.3.12~1/RELEASE_I386 i386
i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5646) (dot 1)

In member function ‘virtual nsresult nsPersistentProperties::Load(nsIInputStream*)’:
nsPersistentProperties.cpp:130:
 warning: ‘backup_char’ may be used uninitialized in this function
 note: ‘backup_char’ was declared here
In member function ‘PRBool nsPropertiesParser::ParseValueCharacter(PRUnichar, const PRUnichar*, const PRUnichar*&, nsAString_internal&)’:
nsPersistentProperties.cpp:130:
 warning: ‘backup_char’ may be used uninitialized in this function
 note: ‘backup_char’ was declared here
In member function ‘nsresult nsPropertiesParser::ParseBuffer(const PRUnichar*, PRUint32)’:
nsPersistentProperties.cpp:130:
 warning: ‘backup_char’ may be used uninitialized in this function
 note: ‘backup_char’ was declared here

This only happens with optimized builds, and it's rather annoying.

Comment 1

[timeless]

ok, i'm willing to accept gcc's complaint.

Comment 2

[timeless]

Attachment: localize variable to calm down compiler

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/caad36ecabef