562539 - deprecated conversion from string constant to char* in nsHttpTransaction::ParseHead

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[timeless]

In member function ‘nsresult nsHttpTransaction::ParseHead
nsHttpTransaction.cpp:783: warning: deprecated conversion from string constant to ‘char*’

Comment 1

[timeless]

Attachment: patch

Comment 2

[Jason Duell]

Comment on attachment 442286 [details] [diff] [review]
patch

Patch is empty?

Comment 3

[timeless]

Attachment: with patch

Comment 4

[Jason Duell]

Comment on attachment 442345 [details] [diff] [review]
with patch

>-            mResponseHead->ParseStatusLine("");
>+            mResponseHead->ParseStatusLine(nsnull);

Any reason why you want to pass null in, instead of just making ParseStatusLine take a const char *?   The latter seems safer to me:  I haven't gone through all the logic, but it seems like it could be easy to blow up with null ptr ref if we pass 0.

The code compiles at least with a "const char *" signature for ParseStatusLine.

Comment 5

[timeless]

Attachment: change prototypes

i read through the code and confirmed that the nspr strcmp function is happy enough about null pointers. but yeah, i'm fine changing the signatures instead.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 442484 [details] [diff] [review]
change prototypes

please limit your lines to 80 characters

Comment 7

[Jason Duell]

Comment on attachment 442484 [details] [diff] [review]
change prototypes

Break the lines so they're less than 80 chars (sorry about advising you differenly on IRC :), and this is +r from me.

Comment 8

[timeless]

Attachment: honor 80 col rule

Comment 9

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/4611e9c3698d