562552 - "your test pilot studies" window is not resizeable and too big for netbooks

Status: VERIFIED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect, P2)

Description

[Igor Velkov]

Attachment: screenshot on eeepc901

"your test pilot studies" window can't fit netbook screen, and can't be resized.

Comment 1

[Jono Xia]

Thanks for reporting this bug, Igor.

Comment 3

[no-one]

The window is also too small to display more than 5 study results at a time even on a high screen resolution. The Firefox Add-ons window can be resized and maximized.

Comment 4

[Jono Xia]

Attachment: Patch to set window size dynamically based on screen size

Attached a patch which makes both the all-studies window and the study detail view window appear at a size dynamically determined by the screen size, instead of being a hard-coded size.  Tested on Mac and Win7 at sizes from 800x600 to 1440x900.

Please review this patch for inclusion in Fx4b2.  Thanks!

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 458280 [details] [diff] [review]
Patch to set window size dynamically based on screen size

>diff --git a/extension/content/all-studies-window.js b/extension/content/all-studies-window.js

>+  sizeWindow: function() {
>+    // Size listboxes based on available screen size, then size window to fit
>+    // list boxes.
>+    let currList = document.getElementById("current-studies-listbox");
>+    let finList = document.getElementById("finished-studies-listbox");
>+    let resultsList = document.getElementById("study-results-listbox");
>+
>+    let screenWidth = window.screen.availWidth;
>+    let screenHeight = window.screen.availHeight;
>+    let width = screenWidth >= 800 ? 700 : screenWidth - 100;
>+    let height = screenHeight >= 800 ? 700 : screenHeight - 100;
>+
>+    height -= 130; // Or whatever is height of title bar plus windowdragbox
>+
>+    currList.width = width;
>+    currList.height = height;
>+    finList.width = width;
>+    finList.height = height;
>+    resultsList.width = width;
>+    resultsList.height = height;

Manually setting sizes on elements is pretty much to be avoided. Is there a reason you can't just use flex to make this work automatically?

Comment 6

[Jono Xia]

I haven't been able to make it work right just using flex.  If I don't set the height of the richlistbox, then the vertical space either goes above the windowdragbox or below the richlistbox, but in no case does it get applied to the richlistbox, which gets very squished vertically.  I tried putting flex="1" on the richlistbox, its enclosing prefpane, the prefpane's enclosing deck, and all three, but to no avail.

Also, if I don't call window.sizeToContents(), the window ignores the height and width attributes I pass it in window.openDialog() and instead appears at an unusably small size.

I'm not sure why, as I'm not a XUL expert, but manually setting the height on the richlistbox and then calling sizeToContents() was the only way I could get it to look right.

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 458280 [details] [diff] [review]
Patch to set window size dynamically based on screen size

Landed: http://hg.mozilla.org/mozilla-central/rev/515d38ffc013

Comment 8

[Dave Townsend [:mossop]]

(In reply to comment #6)
> I haven't been able to make it work right just using flex.  If I don't set the
> height of the richlistbox, then the vertical space either goes above the
> windowdragbox or below the richlistbox, but in no case does it get applied to
> the richlistbox, which gets very squished vertically.  I tried putting flex="1"
> on the richlistbox, its enclosing prefpane, the prefpane's enclosing deck, and
> all three, but to no avail.

We can take it as-is for b2 I think however it would be nice to try to improve it in the near future.

Comment 9

[Tony Chung [:tchung]]

can someone one a netbook verify this is fixed on Firefox 4 beta 2, or trunk?  Igor?

Comment 10

[Tony Chung [:tchung]]

Verified fix on a EeePC with ubuntu running.  All studies window fits with scrollbar.

Mozilla/5.0 (X11; Linux i686; rv:2.0b2) Gecko/20100720 Firefox/4.0b2

also minusing in-testsuite as we should verify this by hand on netbooks for a FFT test.

Comment 11

[Igor Velkov]

Try with Mozilla/5.0 (X11; Linux i686; rv:2.0b3pre) Gecko/20100721 Minefield/4.0b3pre - Build ID: 20100721025955
Window size  fit into display with top and bottom bars. But "finished studies" and "study findings" tabs always empty, and "current studies" tab show me "loading, please wait" forewer.

Comment 12

[Jinghua zhang]

(In reply to comment #11)
> Try with Mozilla/5.0 (X11; Linux i686; rv:2.0b3pre) Gecko/20100721
> Minefield/4.0b3pre - Build ID: 20100721025955
 But "finished studies"
> and "study findings" tabs always empty, and "current studies" tab show me
> "loading, please wait" forewer.

This may related to a different bug https://bugzilla.mozilla.org/show_bug.cgi?id=579080

Thanks for verifying window size is all ok now.

Comment 13

[Tracy Walker [:tracy]]

I'll add a check for resizing to an existing test case