Closed
Bug 562597
Opened 16 years ago
Closed 16 years ago
nanojit: more LOpcode-related renamings
Categories
(Core Graveyard :: Nanojit, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin)
Attachments
(1 file)
|
99.97 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
Bug 560160 did a bunch of auto-renamings. This is a follow-up that does manual ones, ones that were missed, and some cleanups. Mostly straightforward.
The most notable parts:
- added some missing Jtbl static asserts in staticSanityCheck(), and
introduced some #defines to avoid repetition.
- Tweaked the immQ/immD-related functions to strengthen the assertions
within them. Ie. no more immQorD().
- Changed type of initLInsQorD() arg from int64_t to uint64_t to match
everything else. (A careful check of the correctness of the
shifting/casting within this function would be appreciated!)
- Removed qjoin(), it is dead.
- Removed ARGTYPE_LO, it is stupid and hardly used.
Attachment #442344 -
Flags: review?(edwsmith)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 442344 [details] [diff] [review]
patch
shift/casts look fine, nothing else spotted. I went thru the .h files but only skimmed the .cpp files, and didn't test TR.
Attachment #442344 -
Flags: review?(edwsmith) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Whiteboard: fixed-in-nanojit
|
|
Assignee | |
Comment 3•16 years ago
|
||
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
|
|
||
Comment 4•16 years ago
|
||
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin
|
||
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•