Created attachment 442344 [details] [diff] [review] patch Bug 560160 did a bunch of auto-renamings. This is a follow-up that does manual ones, ones that were missed, and some cleanups. Mostly straightforward. The most notable parts: - added some missing Jtbl static asserts in staticSanityCheck(), and introduced some #defines to avoid repetition. - Tweaked the immQ/immD-related functions to strengthen the assertions within them. Ie. no more immQorD(). - Changed type of initLInsQorD() arg from int64_t to uint64_t to match everything else. (A careful check of the correctness of the shifting/casting within this function would be appreciated!) - Removed qjoin(), it is dead. - Removed ARGTYPE_LO, it is stupid and hardly used.
Attachment #442344 - Flags: review?(edwsmith)
Comment on attachment 442344 [details] [diff] [review] patch shift/casts look fine, nothing else spotted. I went thru the .h files but only skimmed the .cpp files, and didn't test TR.
Attachment #442344 - Flags: review?(edwsmith) → review+
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.