56261 - proxyEnv->Get<PrimitiveType>ArrayElements(...) always return NULL

Status: VERIFIED INVALID

(Core Graveyard :: Java: OJI, defect, P3)

Description

[rpallath]

The call  proxyEnv->Get<PrimitiveType>ArrayElement in 
modules/oji/src/ProxyJNI.cpp  always returns null.

The bug is in the Java Plugin code with always returns NULL. A bug has been
filed for the same in SUN Internal bugtraq (ID : 4378653).


When we say proxyEnv->Get<PrimitiveType>ArrayElements(...)
> we actually call the follwoing methods in modules/oji/src/ProxyJNI.cpp file of
Mozilla tree:
> 
>   #define IMPLEMENT_GET_ARRAY_ELEMENTS(methodName, type)                     \
>     static type* JNICALL methodName(JNIEnv *env, type##Array array, jboolean
*isCopy) \
>     {                      \
>         type* outElements = NULL;  \ <- note that here it's set to NULL
>         ^^^^^^^^^^^^^^^^^^^^^^^^ 
>         nsISecureEnv* secureEnv = GetSecureEnv(env);       \
>         nsresult result;    \
>         result = secureEnv->GetArrayElements(type##_type, array, isCopy,
&outElements); \ <- see the code below: outElements never 
> changes
>                                                                         
^^^^^^^^^^^^
>         return outElements;  <- here we always return NULL to user
>     }           



(SUN Internal bugtraq ID : 4378653)

Comment 1

[edburns]

[e-mail]

Comment 2

[Joe Chou]

In the code section below, outElements may get changed in the function call
below before it is returned to the calling party: 
...
result = secureEnv->GetArrayElements(type##_type, array, isCopy, &outElements);
...

Therefore, outElements may not always be null.

Need instructions of how to reproduce the problem. 

Comment 3

[Joe Chou]

This does not look like a bug, and I am changing the resolution to invalid till
I hear something different.

Comment 4

[rpallath]

In the java Plugin code (refer to internal SUN  Bugtraq Id 4378653) outElements
was never changed. So it was always NULL.

suggessted  fix was to change  the interface.
But that is not allowed. The bugtraq bug has been closed
Accordingly closing the same