562616 - [OS X 64] Box shadows with non-zero blur radius don't display in Mac 64 bit builds

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Markus Stange [:mstange]]

Using -moz-box-shadow with blur radius results in the shadow not being rendered, for example in this testcase:
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/box-shadow/boxshadow-blur.html

Unfortunately there doesn't seem to be a reftest that would catch this.

This regressed in the following range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2968d19b0165&tochange=29a6a85fab8e

The cairo update (bug 542605) seems like the most likely culprit to me, but I haven't verified it.

Comment 1

[philippe (part-time)]

Unsurprisingly, text-shadow is equally br0ken.

Comment 2

[Benoit Girard (:BenWa)]

Attachment: Replace float by CGFloat

CGFloat is defined as double on 64-bit so replacing CGFloat with float is wrong.

We've had this same issue come up before (at least 3 times). They show up as these errors:
warning: passing argument X of 'Symbol’ from incompatible pointer type

I don't think we can raise these as errors in GCC but I'm going to fill and bug and try to have the push build report an error if these error are present in the build log. We should be able to avoid these errors in the future as they might be common as we switch to 64-bit.

Comment 3

[Benoit Girard (:BenWa)]

Attachment: Reftest

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 442481 [details] [diff] [review]
Reftest

not a reftest

Comment 5

[Benoit Girard (:BenWa)]

Attachment: Real ref test?

Comment 6

[Benoit Girard (:BenWa)]

Fixed the bit-rot of this patch. It's added to my patch queue so I'll check it in with my next batch of changes.

Comment 7

[Benoit Girard (:BenWa)]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/ad21f6e7d15a