562628 - Crash in [@ nsMIMEInfoBase::LaunchWithIProcess] when the process couldn't initialize for some reason

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Report nsProcess::Init errors back to nsMIMEInfoBase::InitProcess callers

While trying to write a testcase for bug 450239, I was initializing a handler with a directory as the application executable (which I got from code copied from test_handlerService.js, but that's not a problem there).

Next, when trying to use this handler, I got a crash in  nsMIMEInfoBase::LaunchWithIProcess. It appears that whenever nsProcess::Init fails, LaunchWithIProcess will do a NULL dereference.

I don't think it's possible to trigger this bug in normal operation, thus the severity.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 442362 [details] [diff] [review]
Report nsProcess::Init errors back to nsMIMEInfoBase::InitProcess callers

r=bzbarsky.  I'm sorry for the terrible lag here.

Do you need me to check this in?

Comment 2

[Mike Hommey [:glandium]]

> Do you need me to check this in?

If you have other patches to land at the same time, yes, please. Otherwise, I'll take care of it. Thanks.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/29884ff43099