562642 - Error "this.isInBox is not a function" in calDavCalendar.js

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[mguessan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 (.NET CLR 3.5.30729)
Build Identifier: 20100428042218

There are two case errors in calDavCalendar.js around line 927 in function calDav_finalizeUpdatedItems:
- isInBox should be isInbox
- pollInBox should be pollInbox 

Reproducible: Always

Steps to Reproduce:
Refresh a calendar with schedule-inbox support
Actual Results:  
"this.isInBox is not a function" error in Thunderbird console

Expected Results:  
No errors

Comment 1

[mguessan]

Attachment: Fix typo on isInbox and pollInbox in calDavCalendar.js

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 442375 [details] [diff] [review]
Fix typo on isInbox and pollInbox in calDavCalendar.js

Thanks for noticing the error and providing a patch. When attaching a patch please request review from the corresponding module owner or peer listed on <https://wiki.mozilla.org/Calendar:Module_Ownership>. For this small patch I'll take over review. Do you need help to check-in the patch?

Comment 3

[Stefan Sitter [:ssitter]]

Thank you for your contribution!

Pushed to https://hg.mozilla.org/comm-central/rev/5cbb4a9f7d96 --> Fixed.

Comment 4

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/releases/comm-1.9.2/rev/24ad6f4c73fe too